Re: [PATCH net] vxlan: fix missing options_len update on RX with collect metadata

2016-03-03 Thread Daniel Borkmann
On 03/04/2016 01:16 AM, Cong Wang wrote: On Thu, Mar 3, 2016 at 12:58 AM, Daniel Borkmann wrote: On 03/03/2016 02:21 AM, Cong Wang wrote: Why not set it in tun_rx_dst() where it is allocated? Nope, current convention is to only fill options_len when an actual option was detected on RX, f.e.

Re: [PATCH net] vxlan: fix missing options_len update on RX with collect metadata

2016-03-03 Thread Cong Wang
On Thu, Mar 3, 2016 at 12:58 AM, Daniel Borkmann wrote: > On 03/03/2016 02:21 AM, Cong Wang wrote: >> >> Why not set it in tun_rx_dst() where it is allocated? > > > Nope, current convention is to only fill options_len when an actual > option was detected on RX, f.e. see ip_tunnel_info_opts_set() i

Re: [PATCH net] vxlan: fix missing options_len update on RX with collect metadata

2016-03-03 Thread David Miller
From: Daniel Borkmann Date: Wed, 2 Mar 2016 02:32:08 +0100 > When signalling to metadata consumers that the metadata_dst entry > carries additional GBP extension data for vxlan (TUNNEL_VXLAN_OPT), > the dst's vxlan_metadata information is populated, but options_len > is left to zero. F.e. in ovs

Re: [PATCH net] vxlan: fix missing options_len update on RX with collect metadata

2016-03-03 Thread Thomas Graf
On 03/02/16 at 02:32am, Daniel Borkmann wrote: > When signalling to metadata consumers that the metadata_dst entry > carries additional GBP extension data for vxlan (TUNNEL_VXLAN_OPT), > the dst's vxlan_metadata information is populated, but options_len > is left to zero. F.e. in ovs, ovs_flow_key_

Re: [PATCH net] vxlan: fix missing options_len update on RX with collect metadata

2016-03-03 Thread Daniel Borkmann
On 03/03/2016 02:21 AM, Cong Wang wrote: On Tue, Mar 1, 2016 at 5:32 PM, Daniel Borkmann wrote: When signalling to metadata consumers that the metadata_dst entry carries additional GBP extension data for vxlan (TUNNEL_VXLAN_OPT), the dst's vxlan_metadata information is populated, but options_le

Re: [PATCH net] vxlan: fix missing options_len update on RX with collect metadata

2016-03-02 Thread Cong Wang
On Tue, Mar 1, 2016 at 5:32 PM, Daniel Borkmann wrote: > When signalling to metadata consumers that the metadata_dst entry > carries additional GBP extension data for vxlan (TUNNEL_VXLAN_OPT), > the dst's vxlan_metadata information is populated, but options_len > is left to zero. F.e. in ovs, ovs_

[PATCH net] vxlan: fix missing options_len update on RX with collect metadata

2016-03-01 Thread Daniel Borkmann
When signalling to metadata consumers that the metadata_dst entry carries additional GBP extension data for vxlan (TUNNEL_VXLAN_OPT), the dst's vxlan_metadata information is populated, but options_len is left to zero. F.e. in ovs, ovs_flow_key_extract() checks for options_len before extracting the