Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

2017-12-14 Thread Alexey Kodanev
On 12/14/2017 03:36 PM, Stefano Brivio wrote: > On Thu, 14 Dec 2017 14:23:36 +0300 > Alexey Kodanev wrote: > >> On 12/14/2017 03:31 AM, Stefano Brivio wrote: ... >> >> if we move it up in "if (lowerdev) { ..." branch we will be checking the >> presence >> of "lowerdev" and also not calculating i

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

2017-12-14 Thread Stefano Brivio
On Thu, 14 Dec 2017 14:23:36 +0300 Alexey Kodanev wrote: > On 12/14/2017 03:31 AM, Stefano Brivio wrote: > > On Thu, 14 Dec 2017 01:25:40 +0100 > > Matthias Schiffer wrote: > > > >> On 12/14/2017 01:10 AM, Stefano Brivio wrote: > >>> On Thu, 14 Dec 2017 00:57:32 +0100 > >>> Matthias Schiffe

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

2017-12-14 Thread Alexey Kodanev
On 12/14/2017 03:31 AM, Stefano Brivio wrote: > On Thu, 14 Dec 2017 01:25:40 +0100 > Matthias Schiffer wrote: > >> On 12/14/2017 01:10 AM, Stefano Brivio wrote: >>> On Thu, 14 Dec 2017 00:57:32 +0100 >>> Matthias Schiffer wrote: >>> As you note, there is another occurrence of this calcul

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

2017-12-13 Thread Matthias Schiffer
On 12/14/2017 01:31 AM, Stefano Brivio wrote: > On Thu, 14 Dec 2017 01:25:40 +0100 > Matthias Schiffer wrote: > >> On 12/14/2017 01:10 AM, Stefano Brivio wrote: >>> On Thu, 14 Dec 2017 00:57:32 +0100 >>> Matthias Schiffer wrote: >>> As you note, there is another occurrence of this calcul

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

2017-12-13 Thread Stefano Brivio
On Thu, 14 Dec 2017 01:25:40 +0100 Matthias Schiffer wrote: > On 12/14/2017 01:10 AM, Stefano Brivio wrote: > > On Thu, 14 Dec 2017 00:57:32 +0100 > > Matthias Schiffer wrote: > > > >> As you note, there is another occurrence of this calculation in > >> vxlan_config_apply(): > >> > >> > >> [.

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

2017-12-13 Thread Matthias Schiffer
On 12/14/2017 01:10 AM, Stefano Brivio wrote: > On Thu, 14 Dec 2017 00:57:32 +0100 > Matthias Schiffer wrote: > >> As you note, there is another occurrence of this calculation in >> vxlan_config_apply(): >> >> >> [...] >> if (lowerdev) { >> [...] >> max_mtu = lowerdev->mtu

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

2017-12-13 Thread Stefano Brivio
On Thu, 14 Dec 2017 00:57:32 +0100 Matthias Schiffer wrote: > As you note, there is another occurrence of this calculation in > vxlan_config_apply(): > > > [...] > if (lowerdev) { > [...] > max_mtu = lowerdev->mtu - (use_ipv6 ? VXLAN6_HEADROOM : >

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

2017-12-13 Thread Matthias Schiffer
On 12/13/2017 11:37 PM, Stefano Brivio wrote: > Commit a985343ba906 ("vxlan: refactor verification and > application of configuration") introduced a change in the > behaviour of initial MTU setting: earlier, the MTU for a link > created on top of a given lower device, without an initial MTU > speci

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

2017-12-13 Thread Stephen Hemminger
On Wed, 13 Dec 2017 23:37:00 +0100 Stefano Brivio wrote: > Commit a985343ba906 ("vxlan: refactor verification and > application of configuration") introduced a change in the > behaviour of initial MTU setting: earlier, the MTU for a link > created on top of a given lower device, without an initia

[PATCH net] vxlan: Restore initial MTU setting based on lower device

2017-12-13 Thread Stefano Brivio
Commit a985343ba906 ("vxlan: refactor verification and application of configuration") introduced a change in the behaviour of initial MTU setting: earlier, the MTU for a link created on top of a given lower device, without an initial MTU specification, was set to the MTU of the lower device minus h