Re: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing commands

2024-07-31 Thread Heng Qi
On Tue, 30 Jul 2024 18:20:20 -0700, Jakub Kicinski wrote: > On Mon, 29 Jul 2024 20:47:55 +0800 Heng Qi wrote: > > Subject: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing > > commands > > subject currently reads like this is an optimization, could you

Re: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing commands

2024-07-31 Thread Heng Qi
On Wed, 31 Jul 2024 11:13:03 +0800, Jason Wang wrote: > On Wed, Jul 31, 2024 at 9:20 AM Jakub Kicinski wrote: > > > > On Mon, 29 Jul 2024 20:47:55 +0800 Heng Qi wrote: > > > Subject: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing > > > command

Re: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing commands

2024-07-30 Thread Jason Wang
On Wed, Jul 31, 2024 at 9:20 AM Jakub Kicinski wrote: > > On Mon, 29 Jul 2024 20:47:55 +0800 Heng Qi wrote: > > Subject: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing > > commands > > subject currently reads like this is an optimization, could you

Re: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing commands

2024-07-30 Thread Jason Wang
On Mon, Jul 29, 2024 at 8:48 PM Heng Qi wrote: > > From the virtio spec: > > The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL > feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET > and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET. > > The driver must not send v

Re: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing commands

2024-07-30 Thread Jakub Kicinski
On Mon, 29 Jul 2024 20:47:55 +0800 Heng Qi wrote: > Subject: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing > commands subject currently reads like this is an optimization, could you rephrase? > From the virtio spec: > > The driver MUST have

Re: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing commands

2024-07-30 Thread Eugenio Perez Martin
On Mon, Jul 29, 2024 at 2:48 PM Heng Qi wrote: > > From the virtio spec: > > The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL > feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET > and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET. > > The driver must not send v

Re: [PATCH net] virtio_net: Avoid sending unnecessary vq coalescing commands

2024-07-29 Thread Xuan Zhuo
On Mon, 29 Jul 2024 20:47:55 +0800, Heng Qi wrote: > From the virtio spec: > > The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL > feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET > and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET. > > The driver must not send vq no

[PATCH net] virtio_net: Avoid sending unnecessary vq coalescing commands

2024-07-29 Thread Heng Qi
>From the virtio spec: The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET. The driver must not send vq notification coalescing commands if VIRTIO_NET_F_VQ_NOTF_CO