Re: [PATCH net] virtio-net: Fix operstate for virtio when no VIRTIO_NET_F_STATUS

2018-03-22 Thread Jay Vosburgh
Michael S. Tsirkin wrote: >On Thu, Mar 22, 2018 at 12:02:10PM +, Jay Vosburgh wrote: >> Michael S. Tsirkin wrote: >> >> >On Thu, Mar 22, 2018 at 09:05:52AM +, Jay Vosburgh wrote: >> >> The operstate update logic will leave an interface in the >> >> default UNKNOWN operstate if the int

Re: [PATCH net] virtio-net: Fix operstate for virtio when no VIRTIO_NET_F_STATUS

2018-03-22 Thread Michael S. Tsirkin
On Thu, Mar 22, 2018 at 12:02:10PM +, Jay Vosburgh wrote: > Michael S. Tsirkin wrote: > > >On Thu, Mar 22, 2018 at 09:05:52AM +, Jay Vosburgh wrote: > >>The operstate update logic will leave an interface in the > >> default UNKNOWN operstate if the interface carrier state never change

Re: [PATCH net] virtio-net: Fix operstate for virtio when no VIRTIO_NET_F_STATUS

2018-03-22 Thread Jay Vosburgh
Michael S. Tsirkin wrote: >On Thu, Mar 22, 2018 at 09:05:52AM +, Jay Vosburgh wrote: >> The operstate update logic will leave an interface in the >> default UNKNOWN operstate if the interface carrier state never changes >> from the default carrier up state set at creation. This includes

Re: [PATCH net] virtio-net: Fix operstate for virtio when no VIRTIO_NET_F_STATUS

2018-03-22 Thread Michael S. Tsirkin
On Thu, Mar 22, 2018 at 09:05:52AM +, Jay Vosburgh wrote: > The operstate update logic will leave an interface in the > default UNKNOWN operstate if the interface carrier state never changes > from the default carrier up state set at creation. This includes the > case of an explicit call

[PATCH net] virtio-net: Fix operstate for virtio when no VIRTIO_NET_F_STATUS

2018-03-22 Thread Jay Vosburgh
The operstate update logic will leave an interface in the default UNKNOWN operstate if the interface carrier state never changes from the default carrier up state set at creation. This includes the case of an explicit call to netif_carrier_on, as the carrier on to on transition has no effe