Re: [PATCH net] udp: on peeking bad csum, drop packets even if not at head

2017-08-21 Thread Willem de Bruijn
On Mon, Aug 21, 2017 at 8:12 PM, Willem de Bruijn wrote: > On Mon, Aug 21, 2017 at 6:40 PM, Eric Dumazet wrote: >> On Mon, 2017-08-21 at 17:39 -0400, Willem de Bruijn wrote: >>> From: Willem de Bruijn >>> >>> When peeking, if a bad csum is discovered, the skb is unlinked from >>> the queue with

Re: [PATCH net] udp: on peeking bad csum, drop packets even if not at head

2017-08-21 Thread Willem de Bruijn
On Mon, Aug 21, 2017 at 6:40 PM, Eric Dumazet wrote: > On Mon, 2017-08-21 at 17:39 -0400, Willem de Bruijn wrote: >> From: Willem de Bruijn >> >> When peeking, if a bad csum is discovered, the skb is unlinked from >> the queue with __sk_queue_drop_skb and the peek operation restarted. >> >> __sk_

Re: [PATCH net] udp: on peeking bad csum, drop packets even if not at head

2017-08-21 Thread Eric Dumazet
On Mon, 2017-08-21 at 17:39 -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > When peeking, if a bad csum is discovered, the skb is unlinked from > the queue with __sk_queue_drop_skb and the peek operation restarted. > > __sk_queue_drop_skb only drops packets that match the queue head.

Re: [PATCH net] udp: on peeking bad csum, drop packets even if not at head

2017-08-21 Thread Willem de Bruijn
On Mon, Aug 21, 2017 at 5:39 PM, Willem de Bruijn wrote: > From: Willem de Bruijn > > When peeking, if a bad csum is discovered, the skb is unlinked from > the queue with __sk_queue_drop_skb and the peek operation restarted. > > __sk_queue_drop_skb only drops packets that match the queue head. Wi

[PATCH net] udp: on peeking bad csum, drop packets even if not at head

2017-08-21 Thread Willem de Bruijn
From: Willem de Bruijn When peeking, if a bad csum is discovered, the skb is unlinked from the queue with __sk_queue_drop_skb and the peek operation restarted. __sk_queue_drop_skb only drops packets that match the queue head. With sk_peek_off, the skb need not be at head, causing the call to fai