Re: [PATCH net] udp: fix IP_CHECKSUM handling

2016-10-26 Thread David Miller
From: Eric Dumazet Date: Sun, 23 Oct 2016 18:03:06 -0700 > From: Eric Dumazet > > First bug was added in commit ad6f939ab193 ("ip: Add offset parameter to > ip_cmsg_recv") : Tom missed that ipv4 udp messages could be received on > AF_INET6 socket. ip_cmsg_recv(msg, skb) should have been replace

Re: [PATCH net] udp: fix IP_CHECKSUM handling

2016-10-25 Thread Eric Dumazet
On Tue, 2016-10-25 at 15:43 -0400, Willem de Bruijn wrote: > On Sun, Oct 23, 2016 at 9:03 PM, Eric Dumazet wrote: > > From: Eric Dumazet > > > > First bug was added in commit ad6f939ab193 ("ip: Add offset parameter to > > ip_cmsg_recv") : Tom missed that ipv4 udp messages could be received on > >

Re: [PATCH net] udp: fix IP_CHECKSUM handling

2016-10-25 Thread Willem de Bruijn
On Sun, Oct 23, 2016 at 9:03 PM, Eric Dumazet wrote: > From: Eric Dumazet > > First bug was added in commit ad6f939ab193 ("ip: Add offset parameter to > ip_cmsg_recv") : Tom missed that ipv4 udp messages could be received on > AF_INET6 socket. ip_cmsg_recv(msg, skb) should have been replaced by >

[PATCH net] udp: fix IP_CHECKSUM handling

2016-10-23 Thread Eric Dumazet
From: Eric Dumazet First bug was added in commit ad6f939ab193 ("ip: Add offset parameter to ip_cmsg_recv") : Tom missed that ipv4 udp messages could be received on AF_INET6 socket. ip_cmsg_recv(msg, skb) should have been replaced by ip_cmsg_recv_offset(msg, skb, sizeof(struct udphdr)); Then comm