Re: [PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.

2020-10-07 Thread Tomas Charvat
Greetings, tg3 with kernel 5.4.69 is able to get into state, that its reseting link forever. From mii-tools -w XXX I can see, that link is going up and down every 3-8 seconds. Take down/up interface doesnt help. However there is no any error in dmesg or anywhere else. Tested kernel is not modula

Re: [PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.

2020-09-10 Thread Baptiste Covolato
Hi Michael, On Sat, Sep 5, 2020 at 2:02 AM Michael Chan wrote: > Now we have AER errors detected on 2 other tg3 devices, not from the > one above with tg3_abort_hw() failure. > > I think this issue that you're reporting is not the same as David's > issue of TX timeout happening at about the same

Re: [PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.

2020-09-08 Thread David Christensen
On 9/3/20 11:28 AM, Michael Chan wrote: If tg3_reset_task() fails, the device state is left in an inconsistent state with IFF_RUNNING still set but NAPI state not enabled. A subsequent operation, such as ifdown or AER error can cause it to soft lock up when it tries to disable NAPI state. Fix i

Re: [PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.

2020-09-05 Thread Michael Chan
On Fri, Sep 4, 2020 at 4:20 PM Baptiste Covolato wrote: > Thank you for proposing this patch. Unfortunately, it appears to make > things worse on my test setup. The problem is a lot easier to > reproduce, and not related to transmit timeout anymore. This patch specifically addresses the issue re

Re: [PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.

2020-09-04 Thread Baptiste Covolato
Hi Michael, On Thu, Sep 3, 2020 at 11:29 AM Michael Chan wrote: > If tg3_reset_task() fails, the device state is left in an inconsistent > state with IFF_RUNNING still set but NAPI state not enabled. A > subsequent operation, such as ifdown or AER error can cause it to > soft lock up when it tri

Re: [PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.

2020-09-03 Thread David Miller
From: Michael Chan Date: Thu, 3 Sep 2020 14:28:54 -0400 > If tg3_reset_task() fails, the device state is left in an inconsistent > state with IFF_RUNNING still set but NAPI state not enabled. A > subsequent operation, such as ifdown or AER error can cause it to > soft lock up when it tries to d

[PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.

2020-09-03 Thread Michael Chan
If tg3_reset_task() fails, the device state is left in an inconsistent state with IFF_RUNNING still set but NAPI state not enabled. A subsequent operation, such as ifdown or AER error can cause it to soft lock up when it tries to disable NAPI state. Fix it by bringing down the device to !IFF_RUNN