Re: [PATCH net] team: team_port_add should check link_up before enable port

2016-12-05 Thread Xin Long
On Sat, Dec 3, 2016 at 10:57 PM, Marcelo Ricardo Leitner wrote: > On Sat, Dec 03, 2016 at 09:42:11PM +0800, Xin Long wrote: >> Now when users add a nic to team dev, the option 'enable' of the port >> is true by default, as team_port_enable enables it after dev_open in >> team_port_add. >> >> But e

Re: [PATCH net] team: team_port_add should check link_up before enable port

2016-12-03 Thread Marcelo Ricardo Leitner
On Sat, Dec 03, 2016 at 09:42:11PM +0800, Xin Long wrote: > Now when users add a nic to team dev, the option 'enable' of the port > is true by default, as team_port_enable enables it after dev_open in > team_port_add. > > But even if the port_dev has no carrier, like it's cable was unpluged, > the

[PATCH net] team: team_port_add should check link_up before enable port

2016-12-03 Thread Xin Long
Now when users add a nic to team dev, the option 'enable' of the port is true by default, as team_port_enable enables it after dev_open in team_port_add. But even if the port_dev has no carrier, like it's cable was unpluged, the port is still enabled. It leads to that team dev couldn't work well i