Re: [PATCH net] team: postpone features update to avoid deadlock

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 09:30:27 +0100 Ivan Vecera wrote: > On Thu, 21 Jan 2021 18:34:52 -0800 > Jakub Kicinski wrote: > > > On Thu, 21 Jan 2021 11:29:37 +0100 Ivan Vecera wrote: > > > On Wed, 20 Jan 2021 15:18:20 -0800 > > > Cong Wang wrote: > > > > On Wed, Jan 20, 2021 at 4:56 AM Ivan Vecera

Re: [PATCH net] team: postpone features update to avoid deadlock

2021-01-22 Thread Ivan Vecera
On Thu, 21 Jan 2021 18:34:52 -0800 Jakub Kicinski wrote: > On Thu, 21 Jan 2021 11:29:37 +0100 Ivan Vecera wrote: > > On Wed, 20 Jan 2021 15:18:20 -0800 > > Cong Wang wrote: > > > On Wed, Jan 20, 2021 at 4:56 AM Ivan Vecera wrote: > > > > > > > Team driver protects port list traversal by

Re: [PATCH net] team: postpone features update to avoid deadlock

2021-01-21 Thread Jakub Kicinski
On Thu, 21 Jan 2021 11:29:37 +0100 Ivan Vecera wrote: > On Wed, 20 Jan 2021 15:18:20 -0800 > Cong Wang wrote: > > On Wed, Jan 20, 2021 at 4:56 AM Ivan Vecera wrote: > > > Team driver protects port list traversal by its team->lock mutex > > > in functions like team_change_mtu(), team_set_rx_mode

Re: [PATCH net] team: postpone features update to avoid deadlock

2021-01-21 Thread Ivan Vecera
On Wed, 20 Jan 2021 15:18:20 -0800 Cong Wang wrote: > On Wed, Jan 20, 2021 at 4:56 AM Ivan Vecera wrote: > > > > To fix the problem __team_compute_features() needs to be postponed > > for these cases. > > Is there any user-visible effect after deferring this feature change? > An user should

Re: [PATCH net] team: postpone features update to avoid deadlock

2021-01-20 Thread Cong Wang
On Wed, Jan 20, 2021 at 4:56 AM Ivan Vecera wrote: > > To fix the problem __team_compute_features() needs to be postponed > for these cases. Is there any user-visible effect after deferring this feature change? Thanks.

Re: [PATCH net] team: postpone features update to avoid deadlock

2021-01-20 Thread Jiri Pirko
Wed, Jan 20, 2021 at 01:23:54PM CET, ivec...@redhat.com wrote: >Team driver protects port list traversal by its team->lock mutex >in functions like team_change_mtu(), team_set_rx_mode(), >team_vlan_rx_{add,del}_vid() etc. >These functions call appropriate callbacks of all enslaved >devices. Some dr

[PATCH net] team: postpone features update to avoid deadlock

2021-01-20 Thread Ivan Vecera
Team driver protects port list traversal by its team->lock mutex in functions like team_change_mtu(), team_set_rx_mode(), team_vlan_rx_{add,del}_vid() etc. These functions call appropriate callbacks of all enslaved devices. Some drivers need to update their features under certain conditions (e.g. T