Re: [PATCH net] team: fix deadlock during setting of MTU

2021-01-20 Thread Ivan Vecera
On Fri, 15 Jan 2021 09:24:05 +0100 Ivan Vecera wrote: > > according to your explanation in the commit message the team->lock > > mutex will be also taken under this rcu lock, so this is bad even > > if dev_set_mtu does not sleep. > > > Hmm, you are right... btw do we need to take this mutex at

Re: [PATCH net] team: fix deadlock during setting of MTU

2021-01-15 Thread Ivan Vecera
On Thu, 14 Jan 2021 16:34:24 -0800 Saeed Mahameed wrote: > On Thu, 2021-01-14 at 12:55 +0100, Ivan Vecera wrote: > > Team driver protects port list traversal in team_change_mtu() > > by its team->lock mutex. This causes a deadlock with certain > > devices that calls netdev_update_features() durin

Re: [PATCH net] team: fix deadlock during setting of MTU

2021-01-14 Thread Saeed Mahameed
On Thu, 2021-01-14 at 12:55 +0100, Ivan Vecera wrote: > Team driver protects port list traversal in team_change_mtu() > by its team->lock mutex. This causes a deadlock with certain > devices that calls netdev_update_features() during their > .ndo_change_mtu() callback. In this case netdev_update_fe

[PATCH net] team: fix deadlock during setting of MTU

2021-01-14 Thread Ivan Vecera
Team driver protects port list traversal in team_change_mtu() by its team->lock mutex. This causes a deadlock with certain devices that calls netdev_update_features() during their .ndo_change_mtu() callback. In this case netdev_update_features() calls team's netdevice notifier team_device_event() t