Re: [PATCH net] tcp: tcp_grow_window() needs to respect tcp_space()

2019-04-16 Thread David Miller
From: Eric Dumazet Date: Tue, 16 Apr 2019 10:55:20 -0700 > For some reason, tcp_grow_window() correctly tests if enough room > is present before attempting to increase tp->rcv_ssthresh, > but does not prevent it to grow past tcp_space() > > This is causing hard to debug issues, like failing > th

[PATCH net] tcp: tcp_grow_window() needs to respect tcp_space()

2019-04-16 Thread Eric Dumazet
For some reason, tcp_grow_window() correctly tests if enough room is present before attempting to increase tp->rcv_ssthresh, but does not prevent it to grow past tcp_space() This is causing hard to debug issues, like failing the (__tcp_select_window(sk) >= tp->rcv_wnd) test in __tcp_ack_snd_check(