Re: [PATCH net] tcp: refresh tcp_mstamp from timers callbacks

2017-12-13 Thread David Miller
From: Eric Dumazet Date: Tue, 12 Dec 2017 18:22:52 -0800 > From: Eric Dumazet > > Only the retransmit timer currently refreshes tcp_mstamp > > We should do the same for delayed acks and keepalives. > > Even if RFC 7323 does not request it, this is consistent to what linux > did in the past, w

Re: [PATCH net] tcp: refresh tcp_mstamp from timers callbacks

2017-12-13 Thread Mike Maloney
Acked-by: Mike Maloney Thanks for the quick fix! On Tue, Dec 12, 2017 at 9:42 PM, Soheil Hassas Yeganeh wrote: > On Tue, Dec 12, 2017 at 9:26 PM, Neal Cardwell wrote: >> On Tue, Dec 12, 2017 at 9:22 PM, Eric Dumazet wrote: >>> From: Eric Dumazet >>> >>> Only the retransmit timer currently r

Re: [PATCH net] tcp: refresh tcp_mstamp from timers callbacks

2017-12-12 Thread Soheil Hassas Yeganeh
On Tue, Dec 12, 2017 at 9:26 PM, Neal Cardwell wrote: > On Tue, Dec 12, 2017 at 9:22 PM, Eric Dumazet wrote: >> From: Eric Dumazet >> >> Only the retransmit timer currently refreshes tcp_mstamp >> >> We should do the same for delayed acks and keepalives. >> >> Even if RFC 7323 does not request i

Re: [PATCH net] tcp: refresh tcp_mstamp from timers callbacks

2017-12-12 Thread Neal Cardwell
On Tue, Dec 12, 2017 at 9:22 PM, Eric Dumazet wrote: > From: Eric Dumazet > > Only the retransmit timer currently refreshes tcp_mstamp > > We should do the same for delayed acks and keepalives. > > Even if RFC 7323 does not request it, this is consistent to what linux > did in the past, when TS v

[PATCH net] tcp: refresh tcp_mstamp from timers callbacks

2017-12-12 Thread Eric Dumazet
From: Eric Dumazet Only the retransmit timer currently refreshes tcp_mstamp We should do the same for delayed acks and keepalives. Even if RFC 7323 does not request it, this is consistent to what linux did in the past, when TS values were based on jiffies. Fixes: 385e20706fac ("tcp: use tp->tc