Re: [PATCH net] tcp: refresh skb timestamp at retransmit time

2016-05-10 Thread David Miller
From: Eric Dumazet Date: Mon, 09 May 2016 20:55:16 -0700 > From: Eric Dumazet > > In the very unlikely case __tcp_retransmit_skb() can not use the cloning > done in tcp_transmit_skb(), we need to refresh skb_mstamp before doing > the copy and transmit, otherwise TCP TS val will be an exact copy

Re: [PATCH net] tcp: refresh skb timestamp at retransmit time

2016-05-10 Thread Eric Dumazet
On Tue, 2016-05-10 at 08:01 -0700, Yuchung Cheng wrote: > On Mon, May 9, 2016 at 8:55 PM, Eric Dumazet wrote: > > From: Eric Dumazet > > > > In the very unlikely case __tcp_retransmit_skb() can not use the cloning > > done in tcp_transmit_skb(), we need to refresh skb_mstamp before doing > > the

Re: [PATCH net] tcp: refresh skb timestamp at retransmit time

2016-05-10 Thread Yuchung Cheng
On Mon, May 9, 2016 at 8:55 PM, Eric Dumazet wrote: > From: Eric Dumazet > > In the very unlikely case __tcp_retransmit_skb() can not use the cloning > done in tcp_transmit_skb(), we need to refresh skb_mstamp before doing > the copy and transmit, otherwise TCP TS val will be an exact copy of > o

[PATCH net] tcp: refresh skb timestamp at retransmit time

2016-05-09 Thread Eric Dumazet
From: Eric Dumazet In the very unlikely case __tcp_retransmit_skb() can not use the cloning done in tcp_transmit_skb(), we need to refresh skb_mstamp before doing the copy and transmit, otherwise TCP TS val will be an exact copy of original transmit. Fixes: 7faee5c0d514 ("tcp: remove TCP_SKB_CB(