Re: [PATCH net] tcp: refine memory limit test in tcp_fragment()

2019-07-03 Thread Eric Dumazet
On 7/2/19 8:27 PM, Tony Lu wrote: > Hello Eric, > > We have applied that commit e358f4af19db ("tcp: tcp_fragment() should > apply sane memory limits") > as a hotpatch in production environment. We found that it will make > tcp long connection reset during sending out packet w

Re: [PATCH net] tcp: refine memory limit test in tcp_fragment()

2019-07-02 Thread Tony Lu
Hello Eric, We have applied that commit e358f4af19db ("tcp: tcp_fragment() should apply sane memory limits") as a hotpatch in production environment. We found that it will make tcp long connection reset during sending out packet when applying that commit.

Re: [PATCH net] tcp: refine memory limit test in tcp_fragment()

2019-06-21 Thread David Miller
From: Eric Dumazet Date: Fri, 21 Jun 2019 06:09:55 -0700 > tcp_fragment() might be called for skbs in the write queue. > > Memory limits might have been exceeded because tcp_sendmsg() only > checks limits at full skb (64KB) boundaries. > > Therefore, we need to make sure tcp_fragment() wont pun

Re: [PATCH net] tcp: refine memory limit test in tcp_fragment()

2019-06-21 Thread Christoph Paasch
> On Jun 21, 2019, at 6:11 AM, Eric Dumazet wrote: > > tcp_fragment() might be called for skbs in the write queue. > > Memory limits might have been exceeded because tcp_sendmsg() only > checks limits at full skb (64KB) boundaries. > > Therefore, we need to make sure tcp_fragment() wont pun

[PATCH net] tcp: refine memory limit test in tcp_fragment()

2019-06-21 Thread Eric Dumazet
tcp_fragment() might be called for skbs in the write queue. Memory limits might have been exceeded because tcp_sendmsg() only checks limits at full skb (64KB) boundaries. Therefore, we need to make sure tcp_fragment() wont punish applications that might have setup very low SO_SNDBUF values. Fixe