Re: [PATCH net] tcp: purge write queue in tcp_connect_init()

2018-05-16 Thread David Miller
From: Eric Dumazet Date: Mon, 14 May 2018 21:14:26 -0700 > syzkaller found a reliable way to crash the host, hitting a BUG() > in __tcp_retransmit_skb() > > Malicous MSG_FASTOPEN is the root cause. We need to purge write queue > in tcp_connect_init() at the point we init snd_una/write_seq. > >

Re: [PATCH net] tcp: purge write queue in tcp_connect_init()

2018-05-15 Thread Neal Cardwell
On Tue, May 15, 2018 at 12:14 AM Eric Dumazet wrote: > syzkaller found a reliable way to crash the host, hitting a BUG() > in __tcp_retransmit_skb() > Malicous MSG_FASTOPEN is the root cause. We need to purge write queue > in tcp_connect_init() at the point we init snd_una/write_seq. > This pat

[PATCH net] tcp: purge write queue in tcp_connect_init()

2018-05-14 Thread Eric Dumazet
syzkaller found a reliable way to crash the host, hitting a BUG() in __tcp_retransmit_skb() Malicous MSG_FASTOPEN is the root cause. We need to purge write queue in tcp_connect_init() at the point we init snd_una/write_seq. This patch also replaces the BUG() by a less intrusive WARN_ON_ONCE() ke