Re: [PATCH net] tcp: make sure EPOLLOUT wont be missed

2019-08-19 Thread David Miller
From: Eric Dumazet Date: Fri, 16 Aug 2019 21:26:22 -0700 > As Jason Baron explained in commit 790ba4566c1a ("tcp: set SOCK_NOSPACE > under memory pressure"), it is crucial we properly set SOCK_NOSPACE > when needed. > > However, Jason patch had a bug, because the 'nonblocking' status > as far as

Re: [PATCH net] tcp: make sure EPOLLOUT wont be missed

2019-08-19 Thread Jason Baron
On 8/17/19 12:26 PM, Eric Dumazet wrote: > > > On 8/17/19 4:19 PM, Jason Baron wrote: >> >> >> On 8/17/19 12:26 AM, Eric Dumazet wrote: >>> As Jason Baron explained in commit 790ba4566c1a ("tcp: set SOCK_NOSPACE >>> under memory pressure"), it is crucial we properly set SOCK_NOSPACE >>> when n

Re: [PATCH net] tcp: make sure EPOLLOUT wont be missed

2019-08-17 Thread Neal Cardwell
On Sat, Aug 17, 2019 at 12:26 AM Eric Dumazet wrote: > > As Jason Baron explained in commit 790ba4566c1a ("tcp: set SOCK_NOSPACE > under memory pressure"), it is crucial we properly set SOCK_NOSPACE > when needed. > > However, Jason patch had a bug, because the 'nonblocking' status > as far as sk_

Re: [PATCH net] tcp: make sure EPOLLOUT wont be missed

2019-08-17 Thread Eric Dumazet
On 8/17/19 4:19 PM, Jason Baron wrote: > > > On 8/17/19 12:26 AM, Eric Dumazet wrote: >> As Jason Baron explained in commit 790ba4566c1a ("tcp: set SOCK_NOSPACE >> under memory pressure"), it is crucial we properly set SOCK_NOSPACE >> when needed. >> >> However, Jason patch had a bug, because

Re: [PATCH net] tcp: make sure EPOLLOUT wont be missed

2019-08-17 Thread Jason Baron
On 8/17/19 12:26 AM, Eric Dumazet wrote: > As Jason Baron explained in commit 790ba4566c1a ("tcp: set SOCK_NOSPACE > under memory pressure"), it is crucial we properly set SOCK_NOSPACE > when needed. > > However, Jason patch had a bug, because the 'nonblocking' status > as far as sk_stream_wait

Re: [PATCH net] tcp: make sure EPOLLOUT wont be missed

2019-08-17 Thread Soheil Hassas Yeganeh
On Sat, Aug 17, 2019 at 12:26 AM Eric Dumazet wrote: > > As Jason Baron explained in commit 790ba4566c1a ("tcp: set SOCK_NOSPACE > under memory pressure"), it is crucial we properly set SOCK_NOSPACE > when needed. > > However, Jason patch had a bug, because the 'nonblocking' status > as far as sk_

[PATCH net] tcp: make sure EPOLLOUT wont be missed

2019-08-16 Thread Eric Dumazet
As Jason Baron explained in commit 790ba4566c1a ("tcp: set SOCK_NOSPACE under memory pressure"), it is crucial we properly set SOCK_NOSPACE when needed. However, Jason patch had a bug, because the 'nonblocking' status as far as sk_stream_wait_memory() is concerned is governed by MSG_DONTWAIT flag