Re: [PATCH net] tcp: make TCP_USER_TIMEOUT accurate for zero window probes

2021-01-23 Thread Jakub Kicinski
On Sat, 23 Jan 2021 16:56:43 -0800 Enke Chen wrote: > On Sat, Jan 23, 2021 at 07:19:13PM -0500, Neal Cardwell wrote: > > On Fri, Jan 22, 2021 at 9:45 PM Enke Chen wrote: > > > On Fri, Jan 22, 2021 at 06:34:24PM -0800, Jakub Kicinski wrote: > > > > On Fri, 22 Jan 2021 18:28:23 -0800 Enke Chen w

Re: [PATCH net] tcp: make TCP_USER_TIMEOUT accurate for zero window probes

2021-01-23 Thread Enke Chen
Hi, Neal: What you described is more accurate, and is correct. Thanks. -- Enke On Sat, Jan 23, 2021 at 07:19:13PM -0500, Neal Cardwell wrote: > On Fri, Jan 22, 2021 at 9:45 PM Enke Chen wrote: > > > > Hi, Jakub: > > > > On Fri, Jan 22, 2021 at 06:34:24PM -0800, Jakub Kicinski wrote: > > > On F

Re: [PATCH net] tcp: make TCP_USER_TIMEOUT accurate for zero window probes

2021-01-22 Thread Enke Chen
Hi, Jakub: On Fri, Jan 22, 2021 at 06:34:24PM -0800, Jakub Kicinski wrote: > On Fri, 22 Jan 2021 18:28:23 -0800 Enke Chen wrote: > > Hi, Jakub: > > > > In terms of backporting, this patch should go together with: > > > > 9d9b1ee0b2d1 tcp: fix TCP_USER_TIMEOUT with zero window > > As in it:

Re: [PATCH net] tcp: make TCP_USER_TIMEOUT accurate for zero window probes

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 18:28:23 -0800 Enke Chen wrote: > Hi, Jakub: > > In terms of backporting, this patch should go together with: > > 9d9b1ee0b2d1 tcp: fix TCP_USER_TIMEOUT with zero window As in it: Fixes: 9d9b1ee0b2d1 tcp: fix TCP_USER_TIMEOUT with zero window or does it further fix the

Re: [PATCH net] tcp: make TCP_USER_TIMEOUT accurate for zero window probes

2021-01-22 Thread Enke Chen
Hi, Jakub: In terms of backporting, this patch should go together with: 9d9b1ee0b2d1 tcp: fix TCP_USER_TIMEOUT with zero window Thanks. -- Enke On Fri, Jan 22, 2021 at 05:43:25PM -0800, Jakub Kicinski wrote: > On Fri, 22 Jan 2021 11:13:06 -0800 Enke Chen wrote: > > From: Enke Chen > > >

Re: [PATCH net] tcp: make TCP_USER_TIMEOUT accurate for zero window probes

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 11:13:06 -0800 Enke Chen wrote: > From: Enke Chen > > The TCP_USER_TIMEOUT is checked by the 0-window probe timer. As the > timer has backoff with a max interval of about two minutes, the > actual timeout for TCP_USER_TIMEOUT can be off by up to two minutes. > > In this patch

[PATCH net] tcp: make TCP_USER_TIMEOUT accurate for zero window probes

2021-01-22 Thread Enke Chen
From: Enke Chen The TCP_USER_TIMEOUT is checked by the 0-window probe timer. As the timer has backoff with a max interval of about two minutes, the actual timeout for TCP_USER_TIMEOUT can be off by up to two minutes. In this patch the TCP_USER_TIMEOUT is made more accurate by taking it into acco