Re: [PATCH net] tcp: init tcp_options before using it.

2017-05-09 Thread Eric Dumazet
On Tue, 2017-05-09 at 21:22 +0800, Hangbin Liu wrote: > On Mon, May 08, 2017 at 07:49:23AM -0700, Eric Dumazet wrote: > > On Mon, 2017-05-08 at 17:57 +0800, Hangbin Liu wrote: > > > I searched 4308fc58dced ("tcp: Document use of undefined variable") in > > > archive list, but did not find the threa

Re: [PATCH net] tcp: init tcp_options before using it.

2017-05-09 Thread Hangbin Liu
On Mon, May 08, 2017 at 07:49:23AM -0700, Eric Dumazet wrote: > On Mon, 2017-05-08 at 17:57 +0800, Hangbin Liu wrote: > > I searched 4308fc58dced ("tcp: Document use of undefined variable") in > > archive list, but did not find the thread. So I'm not sure why we only > > add a description about un-

Re: [PATCH net] tcp: init tcp_options before using it.

2017-05-08 Thread Eric Dumazet
On Mon, 2017-05-08 at 17:57 +0800, Hangbin Liu wrote: > I searched 4308fc58dced ("tcp: Document use of undefined variable") in > archive list, but did not find the thread. So I'm not sure why we only > add a description about un-initialized value. > > Even we don't use tmp_opt.sack_ok, I think it

[PATCH net] tcp: init tcp_options before using it.

2017-05-08 Thread Hangbin Liu
I searched 4308fc58dced ("tcp: Document use of undefined variable") in archive list, but did not find the thread. So I'm not sure why we only add a description about un-initialized value. Even we don't use tmp_opt.sack_ok, I think it would be more safe to initialize the value before using it. Just