Re: [PATCH net] tcp: inherit timestamp on mtu probe

2019-08-28 Thread David Miller
From: Willem de Bruijn Date: Tue, 27 Aug 2019 15:09:33 -0400 > From: Willem de Bruijn > > TCP associates tx timestamp requests with a byte in the bytestream. > If merging skbs in tcp_mtu_probe, migrate the tstamp request. > > Similar to MSG_EOR, do not allow moving a timestamp from any segment

Re: [PATCH net] tcp: inherit timestamp on mtu probe

2019-08-27 Thread Eric Dumazet
On Tue, Aug 27, 2019 at 11:16 PM Willem de Bruijn wrote: > > On Tue, Aug 27, 2019 at 4:58 PM Eric Dumazet wrote: > > > > On Tue, Aug 27, 2019 at 10:54 PM Willem de Bruijn > > wrote: > > > > > Sure, that's more descriptive. > > > > > > One caveat, the function is exposed in a header, so it's a >

Re: [PATCH net] tcp: inherit timestamp on mtu probe

2019-08-27 Thread Willem de Bruijn
On Tue, Aug 27, 2019 at 4:58 PM Eric Dumazet wrote: > > On Tue, Aug 27, 2019 at 10:54 PM Willem de Bruijn > wrote: > > > Sure, that's more descriptive. > > > > One caveat, the function is exposed in a header, so it's a > > bit more churn. If you don't mind that, I'll send the v2. > > Oh right it

Re: [PATCH net] tcp: inherit timestamp on mtu probe

2019-08-27 Thread Eric Dumazet
On Tue, Aug 27, 2019 at 10:54 PM Willem de Bruijn wrote: > Sure, that's more descriptive. > > One caveat, the function is exposed in a header, so it's a > bit more churn. If you don't mind that, I'll send the v2. Oh right it is also used from tcp_shifted_skb() after Martin KaFai Lau fix ...

Re: [PATCH net] tcp: inherit timestamp on mtu probe

2019-08-27 Thread Willem de Bruijn
On Tue, Aug 27, 2019 at 4:07 PM Eric Dumazet wrote: > > On Tue, Aug 27, 2019 at 9:09 PM Willem de Bruijn > wrote: > > > > From: Willem de Bruijn > > > > TCP associates tx timestamp requests with a byte in the bytestream. > > If merging skbs in tcp_mtu_probe, migrate the tstamp request. > > > > S

Re: [PATCH net] tcp: inherit timestamp on mtu probe

2019-08-27 Thread Eric Dumazet
On Tue, Aug 27, 2019 at 9:09 PM Willem de Bruijn wrote: > > From: Willem de Bruijn > > TCP associates tx timestamp requests with a byte in the bytestream. > If merging skbs in tcp_mtu_probe, migrate the tstamp request. > > Similar to MSG_EOR, do not allow moving a timestamp from any segment > in

[PATCH net] tcp: inherit timestamp on mtu probe

2019-08-27 Thread Willem de Bruijn
From: Willem de Bruijn TCP associates tx timestamp requests with a byte in the bytestream. If merging skbs in tcp_mtu_probe, migrate the tstamp request. Similar to MSG_EOR, do not allow moving a timestamp from any segment in the probe but the last. This to avoid merging multiple timestamps. Tes