Re: [PATCH net] tcp: fix to update snd_wl1 in bulk receiver fast path

2020-10-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 22 Oct 2020 10:33:31 -0400 you wrote: > From: Neal Cardwell > > In the header prediction fast path for a bulk data receiver, if no > data is newly acknowledged then we do not call tcp_ack() and do not > call tcp_ack_up

Re: [PATCH net] tcp: fix to update snd_wl1 in bulk receiver fast path

2020-10-22 Thread Jakub Kicinski
On Thu, 22 Oct 2020 10:33:31 -0400 Neal Cardwell wrote: > From: Neal Cardwell > > In the header prediction fast path for a bulk data receiver, if no > data is newly acknowledged then we do not call tcp_ack() and do not > call tcp_ack_update_window(). This means that a bulk receiver that > receive

Re: [PATCH net] tcp: fix to update snd_wl1 in bulk receiver fast path

2020-10-22 Thread Jakub Kicinski
On Thu, 22 Oct 2020 13:04:04 -0400 Neal Cardwell wrote: > > In that case - can I slap: > > > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > > > on it? > > Yes, slapping that Fixes footer on it sounds fine to me. I see > that it does apply cleanly to 1da177e4c3f4. FWIW even if it didn't - my mod

Re: [PATCH net] tcp: fix to update snd_wl1 in bulk receiver fast path

2020-10-22 Thread Jakub Kicinski
On Thu, 22 Oct 2020 10:33:31 -0400 Neal Cardwell wrote: > From: Neal Cardwell > > In the header prediction fast path for a bulk data receiver, if no > data is newly acknowledged then we do not call tcp_ack() and do not > call tcp_ack_update_window(). This means that a bulk receiver that > receive

[PATCH net] tcp: fix to update snd_wl1 in bulk receiver fast path

2020-10-22 Thread Neal Cardwell
From: Neal Cardwell In the header prediction fast path for a bulk data receiver, if no data is newly acknowledged then we do not call tcp_ack() and do not call tcp_ack_update_window(). This means that a bulk receiver that receives large amounts of data can have the incoming sequence numbers wrap,