Re: [PATCH net] tcp: fix refcnt leak with ebpf congestion control

2017-08-25 Thread David Miller
From: Sabrina Dubroca Date: Fri, 25 Aug 2017 13:10:12 +0200 > There are a few bugs around refcnt handling in the new BPF congestion > control setsockopt: > > - The new ca is assigned to icsk->icsk_ca_ops even in the case where we >cannot get a reference on it. This would lead to a use after

Re: [PATCH net] tcp: fix refcnt leak with ebpf congestion control

2017-08-25 Thread Lawrence Brakmo
On 8/25/17, 4:10 AM, "Sabrina Dubroca" wrote: There are a few bugs around refcnt handling in the new BPF congestion control setsockopt: - The new ca is assigned to icsk->icsk_ca_ops even in the case where we cannot get a reference on it. This would lead to a use after fr

[PATCH net] tcp: fix refcnt leak with ebpf congestion control

2017-08-25 Thread Sabrina Dubroca
There are a few bugs around refcnt handling in the new BPF congestion control setsockopt: - The new ca is assigned to icsk->icsk_ca_ops even in the case where we cannot get a reference on it. This would lead to a use after free, since that ca is going away soon. - Changing the congestion