Re: [PATCH net] tcp: fix possible deadlock in TCP stack vs BPF filter

2017-08-14 Thread David Miller
From: Eric Dumazet Date: Mon, 14 Aug 2017 17:44:43 -0700 > From: Eric Dumazet > > Filtering the ACK packet was not put at the right place. > > At this place, we already allocated a child and put it > into accept queue. > > We absolutely need to call tcp_child_process() to release > its spinlo

[PATCH net] tcp: fix possible deadlock in TCP stack vs BPF filter

2017-08-14 Thread Eric Dumazet
From: Eric Dumazet Filtering the ACK packet was not put at the right place. At this place, we already allocated a child and put it into accept queue. We absolutely need to call tcp_child_process() to release its spinlock, or we will deadlock at accept() or close() time. Found by syzkaller team