Re: [PATCH net] tcp: fix a race in inet_diag_dump_icsk()

2018-12-20 Thread David Miller
From: Eric Dumazet Date: Thu, 20 Dec 2018 15:28:56 -0800 > Alexei reported use after frees in inet_diag_dump_icsk() [1] > > Because we use refcount_set() when various sockets are setup and > inserted into ehash, we also need to make sure inet_diag_dump_icsk() > wont race with the refcount_set()

Re: [PATCH net] tcp: fix a race in inet_diag_dump_icsk()

2018-12-20 Thread Jonathan Lemon
Acked-by: Jonathan Lemon On 20 Dec 2018, at 15:28, Eric Dumazet wrote: Alexei reported use after frees in inet_diag_dump_icsk() [1] Because we use refcount_set() when various sockets are setup and inserted into ehash, we also need to make sure inet_diag_dump_icsk() wont race with the refcount

[PATCH net] tcp: fix a race in inet_diag_dump_icsk()

2018-12-20 Thread Eric Dumazet
Alexei reported use after frees in inet_diag_dump_icsk() [1] Because we use refcount_set() when various sockets are setup and inserted into ehash, we also need to make sure inet_diag_dump_icsk() wont race with the refcount_set() operations. Jonathan Lemon sent a patch changing net_twsk_hashdance(