Re: [PATCH net] tcp: fix a possible lockdep splat in tcp_done()

2019-10-15 Thread David Miller
From: Eric Dumazet Date: Mon, 14 Oct 2019 06:47:57 -0700 > syzbot found that if __inet_inherit_port() returns an error, > we call tcp_done() after inet_csk_prepare_forced_close(), > meaning the socket lock is no longer held. > > We might fix this in a different way in net-next, but > for 5.4 it

[PATCH net] tcp: fix a possible lockdep splat in tcp_done()

2019-10-14 Thread Eric Dumazet
syzbot found that if __inet_inherit_port() returns an error, we call tcp_done() after inet_csk_prepare_forced_close(), meaning the socket lock is no longer held. We might fix this in a different way in net-next, but for 5.4 it seems safer to relax the lockdep check. Fixes: d983ea6f16b8 ("tcp: add