Re: [PATCH net] tcp: fix TCP_SKB_CB(skb)->tcp_tw_isn not being used

2021-01-14 Thread Pengcheng Yang
On Fri, Jan 15, 2021 at 1:12 AM Eric Dumazet wrote: > > On Thu, Jan 14, 2021 at 5:53 PM Jakub Kicinski wrote: > > > > On Tue, 29 Dec 2020 05:59:20 +0800 Pengcheng Yang wrote: > > > TCP_SKB_CB(skb)->tcp_tw_isn contains an ISN, chosen by > > > tcp_timewait_state_process() , when SYN is received in

Re: [PATCH net] tcp: fix TCP_SKB_CB(skb)->tcp_tw_isn not being used

2021-01-14 Thread Jakub Kicinski
On Tue, 29 Dec 2020 05:59:20 +0800 Pengcheng Yang wrote: > TCP_SKB_CB(skb)->tcp_tw_isn contains an ISN, chosen by > tcp_timewait_state_process() , when SYN is received in TIMEWAIT state. > But tcp_tw_isn is not used because it is overwritten by > tcp_v4_restore_cb() after commit eeea10b83a13 ("tcp:

[PATCH net] tcp: fix TCP_SKB_CB(skb)->tcp_tw_isn not being used

2021-01-14 Thread Pengcheng Yang
TCP_SKB_CB(skb)->tcp_tw_isn contains an ISN, chosen by tcp_timewait_state_process() , when SYN is received in TIMEWAIT state. But tcp_tw_isn is not used because it is overwritten by tcp_v4_restore_cb() after commit eeea10b83a13 ("tcp: add tcp_v4_fill_cb()/tcp_v4_restore_cb()"). To fix this case, w