Re: [PATCH net] tcp: do not underestimate skb->truesize in tcp_trim_head()

2017-04-28 Thread David Miller
From: Andrey Konovalov Date: Thu, 27 Apr 2017 13:49:57 +0200 > On Thu, Apr 27, 2017 at 2:15 AM, Eric Dumazet wrote: >> From: Eric Dumazet >> >> Andrey found a way to trigger the WARN_ON_ONCE(delta < len) in >> skb_try_coalesce() using syzkaller and a filter attached to a TCP >> socket over loop

Re: [PATCH net] tcp: do not underestimate skb->truesize in tcp_trim_head()

2017-04-27 Thread Andrey Konovalov
On Thu, Apr 27, 2017 at 2:15 AM, Eric Dumazet wrote: > From: Eric Dumazet > > Andrey found a way to trigger the WARN_ON_ONCE(delta < len) in > skb_try_coalesce() using syzkaller and a filter attached to a TCP > socket over loopback interface. > > I believe one issue with looped skbs is that tcp_t

[PATCH net] tcp: do not underestimate skb->truesize in tcp_trim_head()

2017-04-26 Thread Eric Dumazet
From: Eric Dumazet Andrey found a way to trigger the WARN_ON_ONCE(delta < len) in skb_try_coalesce() using syzkaller and a filter attached to a TCP socket over loopback interface. I believe one issue with looped skbs is that tcp_trim_head() can end up producing skb with under estimated truesize.