Re: [PATCH net] tcp: clear tp->retrans_stamp in tcp_finish_connect()

2018-12-19 Thread David Miller
From: Eric Dumazet Date: Wed, 19 Dec 2018 15:27:19 -0800 > On 12/19/2018 01:50 PM, Eric Dumazet wrote: >> tcp_connect() does : >> >> tp->retrans_stamp = tcp_time_stamp(tp); >> >> When 3WHS completes, we need to clear retrans_stamp otherwise >> various things can break. >> >> This bug beca

Re: [PATCH net] tcp: clear tp->retrans_stamp in tcp_finish_connect()

2018-12-19 Thread Eric Dumazet
On 12/19/2018 01:50 PM, Eric Dumazet wrote: > tcp_connect() does : > > tp->retrans_stamp = tcp_time_stamp(tp); > > When 3WHS completes, we need to clear retrans_stamp otherwise > various things can break. > > This bug became more visible after commit b701a99e431d ("tcp: Add > tcp_clamp_r

Re: [PATCH net] tcp: clear tp->retrans_stamp in tcp_finish_connect()

2018-12-19 Thread Neal Cardwell
On Wed, Dec 19, 2018 at 4:50 PM Eric Dumazet wrote: > > tcp_connect() does : > > tp->retrans_stamp = tcp_time_stamp(tp); > > When 3WHS completes, we need to clear retrans_stamp otherwise > various things can break. > > This bug became more visible after commit b701a99e431d ("tcp: Add > tcp_cl

[PATCH net] tcp: clear tp->retrans_stamp in tcp_finish_connect()

2018-12-19 Thread Eric Dumazet
tcp_connect() does : tp->retrans_stamp = tcp_time_stamp(tp); When 3WHS completes, we need to clear retrans_stamp otherwise various things can break. This bug became more visible after commit b701a99e431d ("tcp: Add tcp_clamp_rto_to_user_timeout() helper to improve accuracy"), but predates g