Re: [PATCH net] tcp: better handle TCP_USER_TIMEOUT in SYN_SENT state

2019-09-27 Thread David Miller
From: Eric Dumazet Date: Thu, 26 Sep 2019 15:42:51 -0700 > Yuchung Cheng and Marek Majkowski independently reported a weird > behavior of TCP_USER_TIMEOUT option when used at connect() time. > > When the TCP_USER_TIMEOUT is reached, tcp_write_timeout() > believes the flow should live, and the fo

Re: [PATCH net] tcp: better handle TCP_USER_TIMEOUT in SYN_SENT state

2019-09-27 Thread Yuchung Cheng
On Thu, Sep 26, 2019 at 3:42 PM Eric Dumazet wrote: > > Yuchung Cheng and Marek Majkowski independently reported a weird > behavior of TCP_USER_TIMEOUT option when used at connect() time. > > When the TCP_USER_TIMEOUT is reached, tcp_write_timeout() > believes the flow should live, and the followi

Re: [PATCH net] tcp: better handle TCP_USER_TIMEOUT in SYN_SENT state

2019-09-27 Thread Eric Dumazet
On Fri, Sep 27, 2019 at 5:40 AM Marek Majkowski wrote: > > On 9/27/19 10:25 AM, Jonathan Maxwell wrote: > > Acked-by: Jon Maxwell > > > > Thanks for fixing that Eric. > > > > The patch seems to do the job. > > Tested-by: Marek Majkowski > > Here's a selftest: > Here is the packetdrill test : `

Re: [PATCH net] tcp: better handle TCP_USER_TIMEOUT in SYN_SENT state

2019-09-27 Thread Marek Majkowski
On 9/27/19 10:25 AM, Jonathan Maxwell wrote: > Acked-by: Jon Maxwell > > Thanks for fixing that Eric. > The patch seems to do the job. Tested-by: Marek Majkowski Here's a selftest: ---8<--- From: Marek Majkowski Date: Fri, 27 Sep 2019 13:37:52 +0200 Subject: [PATCH] selftests/net: TCP_USER_T

Re: [PATCH net] tcp: better handle TCP_USER_TIMEOUT in SYN_SENT state

2019-09-27 Thread Jonathan Maxwell
Acked-by: Jon Maxwell Thanks for fixing that Eric. On Fri, Sep 27, 2019 at 8:42 AM Eric Dumazet wrote: > > Yuchung Cheng and Marek Majkowski independently reported a weird > behavior of TCP_USER_TIMEOUT option when used at connect() time. > > When the TCP_USER_TIMEOUT is reached, tcp_write_tim

[PATCH net] tcp: better handle TCP_USER_TIMEOUT in SYN_SENT state

2019-09-26 Thread Eric Dumazet
Yuchung Cheng and Marek Majkowski independently reported a weird behavior of TCP_USER_TIMEOUT option when used at connect() time. When the TCP_USER_TIMEOUT is reached, tcp_write_timeout() believes the flow should live, and the following condition in tcp_clamp_rto_to_user_timeout() programs one jif