Re: [PATCH net] tcp: Always cleanup skb before sending

2017-11-02 Thread Christoph Paasch
On 02/11/17 - 11:26:21, Eric Dumazet wrote: > On Thu, Nov 2, 2017 at 11:24 AM, Christoph Paasch wrote: > > Hi Eric, > > > > On 01/11/17 - 19:21:31, Eric Dumazet wrote: > >> On Wed, 2017-11-01 at 18:00 -0700, Eric Dumazet wrote: > >> > On Wed, 2017-11-01 at 17:10 -0700, Christoph Paasch wrote: > >>

Re: [PATCH net] tcp: Always cleanup skb before sending

2017-11-02 Thread Eric Dumazet
On Thu, Nov 2, 2017 at 11:24 AM, Christoph Paasch wrote: > Hi Eric, > > On 01/11/17 - 19:21:31, Eric Dumazet wrote: >> On Wed, 2017-11-01 at 18:00 -0700, Eric Dumazet wrote: >> > On Wed, 2017-11-01 at 17:10 -0700, Christoph Paasch wrote: >> > >> > > Yes, that looks good to me. Thanks! >> > > >> >

Re: [PATCH net] tcp: Always cleanup skb before sending

2017-11-02 Thread Christoph Paasch
Hi Eric, On 01/11/17 - 19:21:31, Eric Dumazet wrote: > On Wed, 2017-11-01 at 18:00 -0700, Eric Dumazet wrote: > > On Wed, 2017-11-01 at 17:10 -0700, Christoph Paasch wrote: > > > > > Yes, that looks good to me. Thanks! > > > > > > But we still need to clean up the skb in tcp_v4_send_reset and >

Re: [PATCH net] tcp: Always cleanup skb before sending

2017-11-02 Thread Christoph Paasch
On 01/11/17 - 18:00:10, Eric Dumazet wrote: > On Wed, 2017-11-01 at 17:10 -0700, Christoph Paasch wrote: > > > Yes, that looks good to me. Thanks! > > > > But we still need to clean up the skb in tcp_v4_send_reset and > > tcp_v4_send_ack, as the fields (e.g., tcp_skb_cb->seq) have been set when >

Re: [PATCH net] tcp: Always cleanup skb before sending

2017-11-01 Thread Eric Dumazet
On Wed, 2017-11-01 at 18:00 -0700, Eric Dumazet wrote: > On Wed, 2017-11-01 at 17:10 -0700, Christoph Paasch wrote: > > > Yes, that looks good to me. Thanks! > > > > But we still need to clean up the skb in tcp_v4_send_reset and > > tcp_v4_send_ack, as the fields (e.g., tcp_skb_cb->seq) have been

Re: [PATCH net] tcp: Always cleanup skb before sending

2017-11-01 Thread Eric Dumazet
On Wed, 2017-11-01 at 17:10 -0700, Christoph Paasch wrote: > Yes, that looks good to me. Thanks! > > But we still need to clean up the skb in tcp_v4_send_reset and > tcp_v4_send_ack, as the fields (e.g., tcp_skb_cb->seq) have been set when > coming from tcp_v4_rcv. You might be confused : ip_sen

Re: [PATCH net] tcp: Always cleanup skb before sending

2017-11-01 Thread Christoph Paasch
On 01/11/17 - 14:53:38, Eric Dumazet wrote: > On Wed, 2017-11-01 at 14:32 -0700, Eric Dumazet wrote: > > On Wed, Nov 1, 2017 at 2:10 PM, Christoph Paasch wrote: > > > Since commit 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache > > > line misses") IPCB/IP6CB is no more at the beginnin

Re: [PATCH net] tcp: Always cleanup skb before sending

2017-11-01 Thread Eric Dumazet
On Wed, 2017-11-01 at 14:32 -0700, Eric Dumazet wrote: > On Wed, Nov 1, 2017 at 2:10 PM, Christoph Paasch wrote: > > Since commit 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache > > line misses") IPCB/IP6CB is no more at the beginning of the tcp_skb_cb. > > This means that on the outp

Re: [PATCH net] tcp: Always cleanup skb before sending

2017-11-01 Thread Eric Dumazet
On Wed, Nov 1, 2017 at 2:10 PM, Christoph Paasch wrote: > Since commit 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache > line misses") IPCB/IP6CB is no more at the beginning of the tcp_skb_cb. > This means that on the output path, we need to make sure that it has > been correctly init

[PATCH net] tcp: Always cleanup skb before sending

2017-11-01 Thread Christoph Paasch
Since commit 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache line misses") IPCB/IP6CB is no more at the beginning of the tcp_skb_cb. This means that on the output path, we need to make sure that it has been correctly initialized to 0, as is done in tcp_transmit_skb. However, when goin