Re: [PATCH net] tap: call skb_probe_transport_header after setting skb->dev

2019-01-07 Thread Christian Borntraeger
On 30.12.2018 23:21, Willem de Bruijn wrote: > From: Willem de Bruijn > > The BPF flow dissector expects either skb->sk or skb->dev set on > all skbs. Delay flow dissection until after skb->dev is set. > > This requires calling from within an rcu read-side critical section. > That is fine, see a

Re: [PATCH net] tap: call skb_probe_transport_header after setting skb->dev

2019-01-01 Thread David Miller
From: Willem de Bruijn Date: Sun, 30 Dec 2018 17:21:05 -0500 > From: Willem de Bruijn > > The BPF flow dissector expects either skb->sk or skb->dev set on > all skbs. Delay flow dissection until after skb->dev is set. > > This requires calling from within an rcu read-side critical section. > T

[PATCH net] tap: call skb_probe_transport_header after setting skb->dev

2018-12-30 Thread Willem de Bruijn
From: Willem de Bruijn The BPF flow dissector expects either skb->sk or skb->dev set on all skbs. Delay flow dissection until after skb->dev is set. This requires calling from within an rcu read-side critical section. That is fine, see also the call from tun_xdp_one. Fixes: d0e13a1488ad ("flow_