Re: [PATCH net] strparser: Fix sign of err codes

2018-03-27 Thread Dave Watson
On 03/26/18 01:44 PM, Tom Herbert wrote: > On Mon, Mar 26, 2018 at 12:31 PM, Dave Watson wrote: > > strp_parser_err is called with a negative code everywhere, which then > > calls abort_parser with a negative code. strp_msg_timeout calls > > abort_parser directly with a positive code. Negate ETI

Re: [PATCH net] strparser: Fix sign of err codes

2018-03-26 Thread Tom Herbert
On Mon, Mar 26, 2018 at 12:31 PM, Dave Watson wrote: > strp_parser_err is called with a negative code everywhere, which then > calls abort_parser with a negative code. strp_msg_timeout calls > abort_parser directly with a positive code. Negate ETIMEDOUT > to match signed-ness of other calls. > >

[PATCH net] strparser: Fix sign of err codes

2018-03-26 Thread Dave Watson
strp_parser_err is called with a negative code everywhere, which then calls abort_parser with a negative code. strp_msg_timeout calls abort_parser directly with a positive code. Negate ETIMEDOUT to match signed-ness of other calls. The default abort_parser callback, strp_abort_strp, sets sk->sk_