Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-09-01 Thread Pravin Shelar
On Tue, Sep 1, 2015 at 2:25 PM, Tom Herbert wrote: > On Tue, Sep 1, 2015 at 2:10 PM, Pravin Shelar wrote: >> On Tue, Sep 1, 2015 at 12:55 PM, Tom Herbert wrote: >>> On Tue, Sep 1, 2015 at 12:20 PM, Pravin Shelar wrote: On Tue, Sep 1, 2015 at 7:19 AM, Tom Herbert wrote: > On Mon, Aug 3

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-09-01 Thread Tom Herbert
On Tue, Sep 1, 2015 at 2:10 PM, Pravin Shelar wrote: > On Tue, Sep 1, 2015 at 12:55 PM, Tom Herbert wrote: >> On Tue, Sep 1, 2015 at 12:20 PM, Pravin Shelar wrote: >>> On Tue, Sep 1, 2015 at 7:19 AM, Tom Herbert wrote: On Mon, Aug 31, 2015 at 10:15 PM, Pravin Shelar wrote: > On Mon, A

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-09-01 Thread Pravin Shelar
On Tue, Sep 1, 2015 at 12:55 PM, Tom Herbert wrote: > On Tue, Sep 1, 2015 at 12:20 PM, Pravin Shelar wrote: >> On Tue, Sep 1, 2015 at 7:19 AM, Tom Herbert wrote: >>> On Mon, Aug 31, 2015 at 10:15 PM, Pravin Shelar wrote: On Mon, Aug 31, 2015 at 9:12 PM, Tom Herbert wrote: > On Mon, Au

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-09-01 Thread Tom Herbert
On Tue, Sep 1, 2015 at 12:20 PM, Pravin Shelar wrote: > On Tue, Sep 1, 2015 at 7:19 AM, Tom Herbert wrote: >> On Mon, Aug 31, 2015 at 10:15 PM, Pravin Shelar wrote: >>> On Mon, Aug 31, 2015 at 9:12 PM, Tom Herbert wrote: On Mon, Aug 31, 2015 at 3:55 PM, Pravin B Shelar wrote: >

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-09-01 Thread Pravin Shelar
On Tue, Sep 1, 2015 at 7:19 AM, Tom Herbert wrote: > On Mon, Aug 31, 2015 at 10:15 PM, Pravin Shelar wrote: >> On Mon, Aug 31, 2015 at 9:12 PM, Tom Herbert wrote: >>> On Mon, Aug 31, 2015 at 3:55 PM, Pravin B Shelar wrote: VXLAN device can receive skb with checksum partial. But the checksu

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-09-01 Thread Tom Herbert
On Mon, Aug 31, 2015 at 10:15 PM, Pravin Shelar wrote: > On Mon, Aug 31, 2015 at 9:12 PM, Tom Herbert wrote: >> On Mon, Aug 31, 2015 at 3:55 PM, Pravin B Shelar wrote: >>> VXLAN device can receive skb with checksum partial. But the checksum >>> offset could be in outer header which is pulled on

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-08-31 Thread Pravin Shelar
On Mon, Aug 31, 2015 at 9:12 PM, Tom Herbert wrote: > On Mon, Aug 31, 2015 at 3:55 PM, Pravin B Shelar wrote: >> VXLAN device can receive skb with checksum partial. But the checksum >> offset could be in outer header which is pulled on receive. Such skb >> can cause the panic when checksum is cal

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-08-31 Thread Tom Herbert
On Mon, Aug 31, 2015 at 3:55 PM, Pravin B Shelar wrote: > VXLAN device can receive skb with checksum partial. But the checksum > offset could be in outer header which is pulled on receive. Such skb > can cause the panic when checksum is calculated on skb. Following patch > fixes the bug by setting

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-08-31 Thread Tom Herbert
On Mon, Aug 31, 2015 at 8:25 PM, Pravin Shelar wrote: > On Mon, Aug 31, 2015 at 4:44 PM, Tom Herbert wrote: >> On Mon, Aug 31, 2015 at 3:55 PM, Pravin B Shelar wrote: >>> VXLAN device can receive skb with checksum partial. But the checksum >>> offset could be in outer header which is pulled on r

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-08-31 Thread Pravin Shelar
On Mon, Aug 31, 2015 at 6:40 PM, Alexei Starovoitov wrote: > On Mon, Aug 31, 2015 at 03:55:46PM -0700, Pravin B Shelar wrote: >> VXLAN device can receive skb with checksum partial. But the checksum >> offset could be in outer header which is pulled on receive. Such skb >> can cause the panic when

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-08-31 Thread Pravin Shelar
On Mon, Aug 31, 2015 at 4:44 PM, Tom Herbert wrote: > On Mon, Aug 31, 2015 at 3:55 PM, Pravin B Shelar wrote: >> VXLAN device can receive skb with checksum partial. But the checksum >> offset could be in outer header which is pulled on receive. Such skb >> can cause the panic when checksum is cal

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-08-31 Thread Alexei Starovoitov
On Mon, Aug 31, 2015 at 03:55:46PM -0700, Pravin B Shelar wrote: > VXLAN device can receive skb with checksum partial. But the checksum > offset could be in outer header which is pulled on receive. Such skb > can cause the panic when checksum is calculated on skb. Following patch > fixes the bug by

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-08-31 Thread Tom Herbert
On Mon, Aug 31, 2015 at 3:55 PM, Pravin B Shelar wrote: > VXLAN device can receive skb with checksum partial. But the checksum > offset could be in outer header which is pulled on receive. Such skb > can cause the panic when checksum is calculated on skb. Following patch > fixes the bug by setting

[PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-08-31 Thread Pravin B Shelar
VXLAN device can receive skb with checksum partial. But the checksum offset could be in outer header which is pulled on receive. Such skb can cause the panic when checksum is calculated on skb. Following patch fixes the bug by setting checksum unnecessary while pulling outer header. ---8<--- [ 13.