From: Eric Dumazet
Date: Mon, 28 Nov 2016 10:17:23 -0800
> It appears that Eli changelog was not very precise, because his bug was
> because of XFRM being involved.
>
> xfrm_output() -> xfrm_output_gso() -> skb_gso_segment()
>
> So XFRM calls skb_gso_segment() before ip_output() or
> ip6_finish
From: Eric Dumazet
Date: Mon, 28 Nov 2016 10:32:15 -0800
> On Mon, 2016-11-28 at 10:17 -0800, Eric Dumazet wrote:
>
>> I was referring to Stephen bug report.
>>
>> It appears that Eli changelog was not very precise, because his bug was
>> because of XFRM being involved.
>>
>> xfrm_output() ->
On Mon, 2016-11-28 at 10:17 -0800, Eric Dumazet wrote:
> I was referring to Stephen bug report.
>
> It appears that Eli changelog was not very precise, because his bug was
> because of XFRM being involved.
>
> xfrm_output() -> xfrm_output_gso() -> skb_gso_segment()
>
> So XFRM calls skb_gso_seg
On Mon, 2016-11-28 at 13:01 -0500, David Miller wrote:
> Hmmm, ip6_finish_output2() also does a proper assignment of skb->protocol,
> therefore why was commit ae148b085876fa771d9ef2c05f85d4b4bf09ce0d
> ("ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()")
> necessary at all?
I was r
From: Eric Dumazet
Date: Mon, 28 Nov 2016 09:34:27 -0800
> On Mon, 2016-11-28 at 08:53 -0800, Eric Dumazet wrote:
>> On Mon, 2016-11-28 at 11:47 -0500, David Miller wrote:
>> > From: Stephen Rothwell
>> > Date: Sun, 27 Nov 2016 13:04:00 +1100
>> >
>> > > [Just for Dave's information]
>> > >
>>
On Mon, Nov 28, 2016 at 8:53 AM, Eric Dumazet wrote:
> On Mon, 2016-11-28 at 11:47 -0500, David Miller wrote:
>> From: Stephen Rothwell
>> Date: Sun, 27 Nov 2016 13:04:00 +1100
>>
>> > [Just for Dave's information]
>> >
>> > On Fri, 25 Nov 2016 13:50:17 +0800 Eli Cooper wrote:
>> >>
>> >> Simila
On Mon, 2016-11-28 at 08:53 -0800, Eric Dumazet wrote:
> On Mon, 2016-11-28 at 11:47 -0500, David Miller wrote:
> > From: Stephen Rothwell
> > Date: Sun, 27 Nov 2016 13:04:00 +1100
> >
> > > [Just for Dave's information]
> > >
> > > On Fri, 25 Nov 2016 13:50:17 +0800 Eli Cooper wrote:
> > >>
>
On Mon, 2016-11-28 at 11:47 -0500, David Miller wrote:
> From: Stephen Rothwell
> Date: Sun, 27 Nov 2016 13:04:00 +1100
>
> > [Just for Dave's information]
> >
> > On Fri, 25 Nov 2016 13:50:17 +0800 Eli Cooper wrote:
> >>
> >> Similar to commit ae148b085876
> >> ("ip6_tunnel: Update skb->protoc
From: Stephen Rothwell
Date: Sun, 27 Nov 2016 13:04:00 +1100
> [Just for Dave's information]
>
> On Fri, 25 Nov 2016 13:50:17 +0800 Eli Cooper wrote:
>>
>> Similar to commit ae148b085876
>> ("ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()"),
>> sit tunnels also need to update
Hi Eli,
[Just for Dave's information]
On Fri, 25 Nov 2016 13:50:17 +0800 Eli Cooper wrote:
>
> Similar to commit ae148b085876
> ("ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()"),
> sit tunnels also need to update skb->protocol; otherwise, TSO/GSO packets
> might not be properl
Similar to commit ae148b085876
("ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()"),
sit tunnels also need to update skb->protocol; otherwise, TSO/GSO packets
might not be properly segmented, which causes the packets being dropped.
Reported-by: Stephen Rothwell
Tested-by: Eli Coop
11 matches
Mail list logo
