Re: [PATCH net] sfc: fix boolreturn.cocci warning and rename function

2020-08-24 Thread David Miller
From: Edward Cree Date: Mon, 24 Aug 2020 16:18:51 +0100 > check_fcs() was returning bool as 0/1, which was a sign that the sense > of the function was unclear: false was good, which doesn't really match > a name like 'check_$thing'. So rename it to ef100_has_fcs_error(), and > use proper bool

[PATCH net] sfc: fix boolreturn.cocci warning and rename function

2020-08-24 Thread Edward Cree
check_fcs() was returning bool as 0/1, which was a sign that the sense of the function was unclear: false was good, which doesn't really match a name like 'check_$thing'. So rename it to ef100_has_fcs_error(), and use proper booleans in the return statements. Reported-by: kernel test robot Si