Re: [PATCH net] selinux: do not report error on connect(AF_UNSPEC)

2019-05-09 Thread David Miller
From: Paolo Abeni Date: Thu, 09 May 2019 10:40:40 +0200 > @DaveM: if it's ok for you, I'll send a revert for this on netdev and > I'll send a v2 via the selinux ML, please let me know! Sure.

Re: [PATCH net] selinux: do not report error on connect(AF_UNSPEC)

2019-05-09 Thread Paul Moore
On Thu, May 9, 2019 at 4:40 AM Paolo Abeni wrote: > On Wed, 2019-05-08 at 17:17 -0400, Paul Moore wrote: > > On Wed, May 8, 2019 at 2:55 PM Stephen Smalley wrote: > > > On 5/8/19 2:27 PM, Marcelo Ricardo Leitner wrote: > > > > On Wed, May 08, 2019 at 02:13:17PM -0400, Stephen Smalley wrote: > > >

Re: [PATCH net] selinux: do not report error on connect(AF_UNSPEC)

2019-05-09 Thread Paolo Abeni
On Wed, 2019-05-08 at 17:17 -0400, Paul Moore wrote: > On Wed, May 8, 2019 at 2:55 PM Stephen Smalley wrote: > > On 5/8/19 2:27 PM, Marcelo Ricardo Leitner wrote: > > > On Wed, May 08, 2019 at 02:13:17PM -0400, Stephen Smalley wrote: > > > > On 5/8/19 2:12 PM, Stephen Smalley wrote: > > > > > On 5

Re: [PATCH net] selinux: do not report error on connect(AF_UNSPEC)

2019-05-08 Thread Paul Moore
On Wed, May 8, 2019 at 2:55 PM Stephen Smalley wrote: > On 5/8/19 2:27 PM, Marcelo Ricardo Leitner wrote: > > On Wed, May 08, 2019 at 02:13:17PM -0400, Stephen Smalley wrote: > >> On 5/8/19 2:12 PM, Stephen Smalley wrote: > >>> On 5/8/19 9:32 AM, Paolo Abeni wrote: > calling connect(AF_UNSPEC

Re: [PATCH net] selinux: do not report error on connect(AF_UNSPEC)

2019-05-08 Thread Stephen Smalley
On 5/8/19 2:27 PM, Marcelo Ricardo Leitner wrote: On Wed, May 08, 2019 at 02:13:17PM -0400, Stephen Smalley wrote: On 5/8/19 2:12 PM, Stephen Smalley wrote: On 5/8/19 9:32 AM, Paolo Abeni wrote: calling connect(AF_UNSPEC) on an already connected TCP socket is an established way to disconnect()

Re: [PATCH net] selinux: do not report error on connect(AF_UNSPEC)

2019-05-08 Thread Marcelo Ricardo Leitner
On Wed, May 08, 2019 at 02:13:17PM -0400, Stephen Smalley wrote: > On 5/8/19 2:12 PM, Stephen Smalley wrote: > > On 5/8/19 9:32 AM, Paolo Abeni wrote: > > > calling connect(AF_UNSPEC) on an already connected TCP socket is an > > > established way to disconnect() such socket. After commit 68741a8ada

Re: [PATCH net] selinux: do not report error on connect(AF_UNSPEC)

2019-05-08 Thread Stephen Smalley
On 5/8/19 2:12 PM, Stephen Smalley wrote: On 5/8/19 9:32 AM, Paolo Abeni wrote: calling connect(AF_UNSPEC) on an already connected TCP socket is an established way to disconnect() such socket. After commit 68741a8adab9 ("selinux: Fix ltp test connect-syscall failure") it no longer works and, in

Re: [PATCH net] selinux: do not report error on connect(AF_UNSPEC)

2019-05-08 Thread Stephen Smalley
On 5/8/19 9:32 AM, Paolo Abeni wrote: calling connect(AF_UNSPEC) on an already connected TCP socket is an established way to disconnect() such socket. After commit 68741a8adab9 ("selinux: Fix ltp test connect-syscall failure") it no longer works and, in the above scenario connect() fails with EAF

Re: [PATCH net] selinux: do not report error on connect(AF_UNSPEC)

2019-05-08 Thread David Miller
From: Paolo Abeni Date: Wed, 8 May 2019 15:32:51 +0200 > calling connect(AF_UNSPEC) on an already connected TCP socket is an > established way to disconnect() such socket. After commit 68741a8adab9 > ("selinux: Fix ltp test connect-syscall failure") it no longer works > and, in the above scenari

Re: [PATCH net] selinux: do not report error on connect(AF_UNSPEC)

2019-05-08 Thread Marcelo Ricardo Leitner
On Wed, May 08, 2019 at 03:32:51PM +0200, Paolo Abeni wrote: > calling connect(AF_UNSPEC) on an already connected TCP socket is an > established way to disconnect() such socket. After commit 68741a8adab9 > ("selinux: Fix ltp test connect-syscall failure") it no longer works > and, in the above scen

[PATCH net] selinux: do not report error on connect(AF_UNSPEC)

2019-05-08 Thread Paolo Abeni
calling connect(AF_UNSPEC) on an already connected TCP socket is an established way to disconnect() such socket. After commit 68741a8adab9 ("selinux: Fix ltp test connect-syscall failure") it no longer works and, in the above scenario connect() fails with EAFNOSUPPORT. Fix the above falling back t