Re: [PATCH net] selftests: fib_rule_tests: Fix icmp proto with ipv6

2019-05-08 Thread David Ahern
On 5/7/19 2:20 AM, Hangbin Liu wrote: > On Tue, Apr 30, 2019 at 12:00:46PM -0600, David Ahern wrote: >> On 4/29/19 8:37 PM, Hangbin Liu wrote: >>> An other issue is The IPv4 rule 'from iif' check test failed while IPv6 >>> passed. I haven't found out the reason yet. >>> >>> # ip -netns testns rule

Re: [PATCH net] selftests: fib_rule_tests: Fix icmp proto with ipv6

2019-05-07 Thread Hangbin Liu
On Tue, Apr 30, 2019 at 12:00:46PM -0600, David Ahern wrote: > On 4/29/19 8:37 PM, Hangbin Liu wrote: > > An other issue is The IPv4 rule 'from iif' check test failed while IPv6 > > passed. I haven't found out the reason yet. > > > > # ip -netns testns rule add from 192.51.100.3 iif dummy0 table 1

Re: [PATCH net] selftests: fib_rule_tests: Fix icmp proto with ipv6

2019-05-01 Thread David Miller
From: David Ahern Date: Mon, 29 Apr 2019 10:30:09 -0700 > From: David Ahern > > A recent commit returns an error if icmp is used as the ip-proto for > IPv6 fib rules. Update fib_rule_tests to send ipv6-icmp instead of icmp. > > Fixes: 5e1a99eae8499 ("ipv4: Add ICMPv6 support when parse route i

Re: [PATCH net] selftests: fib_rule_tests: Fix icmp proto with ipv6

2019-04-30 Thread David Ahern
On 4/29/19 8:37 PM, Hangbin Liu wrote: > An other issue is The IPv4 rule 'from iif' check test failed while IPv6 > passed. I haven't found out the reason yet. > > # ip -netns testns rule add from 192.51.100.3 iif dummy0 table 100 > # ip -netns testns route get 192.51.100.2 from 192.51.100.3 iif du

Re: [PATCH net] selftests: fib_rule_tests: Fix icmp proto with ipv6

2019-04-29 Thread Hangbin Liu
On Mon, Apr 29, 2019 at 10:30:09AM -0700, David Ahern wrote: > From: David Ahern > > A recent commit returns an error if icmp is used as the ip-proto for > IPv6 fib rules. Update fib_rule_tests to send ipv6-icmp instead of icmp. > > Fixes: 5e1a99eae8499 ("ipv4: Add ICMPv6 support when parse rout

[PATCH net] selftests: fib_rule_tests: Fix icmp proto with ipv6

2019-04-29 Thread David Ahern
From: David Ahern A recent commit returns an error if icmp is used as the ip-proto for IPv6 fib rules. Update fib_rule_tests to send ipv6-icmp instead of icmp. Fixes: 5e1a99eae8499 ("ipv4: Add ICMPv6 support when parse route ipproto") Signed-off-by: David Ahern --- tools/testing/selftests/net/