Re: [PATCH net] sctp: remove temporary variable confirm from sctp_packet_transmit

2017-03-21 Thread David Miller
From: Xin Long Date: Sat, 18 Mar 2017 19:12:22 +0800 > Commit c86a773c7802 ("sctp: add dst_pending_confirm flag") introduced > a temporary variable "confirm" in sctp_packet_transmit. > > But it broke the rule that longer lines should be above shorter ones. > Besides, this variable is not necessa

Re: [PATCH net] sctp: remove temporary variable confirm from sctp_packet_transmit

2017-03-18 Thread Neil Horman
On Sat, Mar 18, 2017 at 07:12:22PM +0800, Xin Long wrote: > Commit c86a773c7802 ("sctp: add dst_pending_confirm flag") introduced > a temporary variable "confirm" in sctp_packet_transmit. > > But it broke the rule that longer lines should be above shorter ones. > Besides, this variable is not nece

Re: [PATCH net] sctp: remove temporary variable confirm from sctp_packet_transmit

2017-03-18 Thread Xin Long
On Sat, Mar 18, 2017 at 7:48 PM, Julian Anastasov wrote: > > Hello, > > On Sat, 18 Mar 2017, Xin Long wrote: > >> Commit c86a773c7802 ("sctp: add dst_pending_confirm flag") introduced >> a temporary variable "confirm" in sctp_packet_transmit. >> >> But it broke the rule that longer lines s

Re: [PATCH net] sctp: remove temporary variable confirm from sctp_packet_transmit

2017-03-18 Thread Julian Anastasov
Hello, On Sat, 18 Mar 2017, Xin Long wrote: > Commit c86a773c7802 ("sctp: add dst_pending_confirm flag") introduced > a temporary variable "confirm" in sctp_packet_transmit. > > But it broke the rule that longer lines should be above shorter ones. > Besides, this variable is not necessa

[PATCH net] sctp: remove temporary variable confirm from sctp_packet_transmit

2017-03-18 Thread Xin Long
Commit c86a773c7802 ("sctp: add dst_pending_confirm flag") introduced a temporary variable "confirm" in sctp_packet_transmit. But it broke the rule that longer lines should be above shorter ones. Besides, this variable is not necessary, so this patch is to just remove it and use tp->dst_pending_co