Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-06-04 Thread Xin Long
On Mon, Jun 4, 2018 at 4:34 PM, Dmitry Vyukov wrote: > On Tue, May 29, 2018 at 7:45 PM, Xin Long wrote: >> On Wed, May 30, 2018 at 1:06 AM, Marcelo Ricardo Leitner >> wrote: >>> On Tue, May 29, 2018 at 12:03:46PM -0400, Neal Cardwell wrote: On Tue, May 29, 2018 at 11:45 AM Marcelo Ricardo L

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-06-04 Thread Dmitry Vyukov
On Tue, May 29, 2018 at 7:45 PM, Xin Long wrote: > On Wed, May 30, 2018 at 1:06 AM, Marcelo Ricardo Leitner > wrote: >> On Tue, May 29, 2018 at 12:03:46PM -0400, Neal Cardwell wrote: >>> On Tue, May 29, 2018 at 11:45 AM Marcelo Ricardo Leitner < >>> marcelo.leit...@gmail.com> wrote: >>> > - patch

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Marcelo Ricardo Leitner
On Wed, May 30, 2018 at 01:45:08AM +0800, Xin Long wrote: > If we're counting on max_t to fix this CPU stuck. It should not that > matter if min rto < the value causing that stuck. Yes but putting a floor to rto_{min,max} now is to protect the rtx timer now, not the heartbeat one. > > > > > Anyw

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Xin Long
On Wed, May 30, 2018 at 1:06 AM, Marcelo Ricardo Leitner wrote: > On Tue, May 29, 2018 at 12:03:46PM -0400, Neal Cardwell wrote: >> On Tue, May 29, 2018 at 11:45 AM Marcelo Ricardo Leitner < >> marcelo.leit...@gmail.com> wrote: >> > - patch2 - fix rtx attack vector >> >- Add the floor value to

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Marcelo Ricardo Leitner
On Tue, May 29, 2018 at 12:03:46PM -0400, Neal Cardwell wrote: > On Tue, May 29, 2018 at 11:45 AM Marcelo Ricardo Leitner < > marcelo.leit...@gmail.com> wrote: > > - patch2 - fix rtx attack vector > >- Add the floor value to rto_min to HZ/20 (which fits the values > > that Michael shared o

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Neal Cardwell
On Tue, May 29, 2018 at 11:45 AM Marcelo Ricardo Leitner < marcelo.leit...@gmail.com> wrote: > - patch2 - fix rtx attack vector >- Add the floor value to rto_min to HZ/20 (which fits the values > that Michael shared on the other email) I would encourage allowing minimum RTO values down to

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Marcelo Ricardo Leitner
On Tue, May 29, 2018 at 03:06:06PM +0200, Michael Tuexen wrote: > > On 29. May 2018, at 13:41, Neil Horman wrote: > > > > On Mon, May 28, 2018 at 04:43:15PM -0300, Marcelo Ricardo Leitner wrote: > >> On Sat, May 26, 2018 at 09:01:00PM -0400, Neil Horman wrote: > >>> On Sat, May 26, 2018 at 05:50:

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Michael Tuexen
> On 29. May 2018, at 13:41, Neil Horman wrote: > > On Mon, May 28, 2018 at 04:43:15PM -0300, Marcelo Ricardo Leitner wrote: >> On Sat, May 26, 2018 at 09:01:00PM -0400, Neil Horman wrote: >>> On Sat, May 26, 2018 at 05:50:39PM +0200, Dmitry Vyukov wrote: On Sat, May 26, 2018 at 5:42 PM, Mic

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Neil Horman
On Mon, May 28, 2018 at 04:43:15PM -0300, Marcelo Ricardo Leitner wrote: > On Sat, May 26, 2018 at 09:01:00PM -0400, Neil Horman wrote: > > On Sat, May 26, 2018 at 05:50:39PM +0200, Dmitry Vyukov wrote: > > > On Sat, May 26, 2018 at 5:42 PM, Michael Tuexen > > > wrote: > > > >> On 25. May 2018, at

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-28 Thread Marcelo Ricardo Leitner
On Sat, May 26, 2018 at 09:01:00PM -0400, Neil Horman wrote: > On Sat, May 26, 2018 at 05:50:39PM +0200, Dmitry Vyukov wrote: > > On Sat, May 26, 2018 at 5:42 PM, Michael Tuexen > > wrote: > > >> On 25. May 2018, at 21:13, Neil Horman wrote: > > >> > > >> On Sat, May 26, 2018 at 01:41:02AM +0800,

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-28 Thread Marcelo Ricardo Leitner
On Sun, May 27, 2018 at 10:58:35AM +0200, Michael Tuexen wrote: ... > >>> Patch looks fine, you probably want to note this hard minimum in man(7) > >>> sctp as > >>> well > >>> > >> I'm aware of some signalling networks which use RTO.min of smaller values > >> than 200ms. > >> So could this be r

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-27 Thread Michael Tuexen
> On 26. May 2018, at 17:50, Dmitry Vyukov wrote: > > On Sat, May 26, 2018 at 5:42 PM, Michael Tuexen > wrote: >>> On 25. May 2018, at 21:13, Neil Horman wrote: >>> >>> On Sat, May 26, 2018 at 01:41:02AM +0800, Xin Long wrote: syzbot reported a rcu_sched self-detected stall on CPU which i

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-26 Thread Neil Horman
On Sat, May 26, 2018 at 05:50:39PM +0200, Dmitry Vyukov wrote: > On Sat, May 26, 2018 at 5:42 PM, Michael Tuexen > wrote: > >> On 25. May 2018, at 21:13, Neil Horman wrote: > >> > >> On Sat, May 26, 2018 at 01:41:02AM +0800, Xin Long wrote: > >>> syzbot reported a rcu_sched self-detected stall on

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-26 Thread Dmitry Vyukov
On Sat, May 26, 2018 at 5:42 PM, Michael Tuexen wrote: >> On 25. May 2018, at 21:13, Neil Horman wrote: >> >> On Sat, May 26, 2018 at 01:41:02AM +0800, Xin Long wrote: >>> syzbot reported a rcu_sched self-detected stall on CPU which is caused >>> by too small value set on rto_min with SCTP_RTOINF

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-26 Thread Michael Tuexen
> On 25. May 2018, at 21:13, Neil Horman wrote: > > On Sat, May 26, 2018 at 01:41:02AM +0800, Xin Long wrote: >> syzbot reported a rcu_sched self-detected stall on CPU which is caused >> by too small value set on rto_min with SCTP_RTOINFO sockopt. With this >> value, hb_timer will get stuck there

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-25 Thread Neil Horman
On Sat, May 26, 2018 at 01:41:02AM +0800, Xin Long wrote: > syzbot reported a rcu_sched self-detected stall on CPU which is caused > by too small value set on rto_min with SCTP_RTOINFO sockopt. With this > value, hb_timer will get stuck there, as in its timer handler it starts > this timer again wi

[PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-25 Thread Xin Long
syzbot reported a rcu_sched self-detected stall on CPU which is caused by too small value set on rto_min with SCTP_RTOINFO sockopt. With this value, hb_timer will get stuck there, as in its timer handler it starts this timer again with this value, then goes to the timer handler again. This problem