Re: [PATCH net] sctp: increase sk_wmem_alloc when head->truesize is increased

2018-11-27 Thread David Miller
From: Xin Long Date: Mon, 26 Nov 2018 14:52:44 +0800 > I changed to count sk_wmem_alloc by skb truesize instead of 1 to > fix the sk_wmem_alloc leak caused by later truesize's change in > xfrm in Commit 02968ccf0125 ("sctp: count sk_wmem_alloc by skb > truesize in sctp_packet_transmit"). > > But

Re: [PATCH net] sctp: increase sk_wmem_alloc when head->truesize is increased

2018-11-26 Thread Xin Long
On Mon, Nov 26, 2018 at 9:27 PM Neil Horman wrote: > > On Mon, Nov 26, 2018 at 02:52:44PM +0800, Xin Long wrote: > > I changed to count sk_wmem_alloc by skb truesize instead of 1 to > > fix the sk_wmem_alloc leak caused by later truesize's change in > > xfrm in Commit 02968ccf0125 ("sctp: count sk

Re: [PATCH net] sctp: increase sk_wmem_alloc when head->truesize is increased

2018-11-26 Thread Neil Horman
On Mon, Nov 26, 2018 at 02:52:44PM +0800, Xin Long wrote: > I changed to count sk_wmem_alloc by skb truesize instead of 1 to > fix the sk_wmem_alloc leak caused by later truesize's change in > xfrm in Commit 02968ccf0125 ("sctp: count sk_wmem_alloc by skb > truesize in sctp_packet_transmit"). > >

Re: [PATCH net] sctp: increase sk_wmem_alloc when head->truesize is increased

2018-11-26 Thread Marcelo Ricardo Leitner
On Mon, Nov 26, 2018 at 02:52:44PM +0800, Xin Long wrote: > I changed to count sk_wmem_alloc by skb truesize instead of 1 to > fix the sk_wmem_alloc leak caused by later truesize's change in > xfrm in Commit 02968ccf0125 ("sctp: count sk_wmem_alloc by skb > truesize in sctp_packet_transmit"). > >

[PATCH net] sctp: increase sk_wmem_alloc when head->truesize is increased

2018-11-25 Thread Xin Long
I changed to count sk_wmem_alloc by skb truesize instead of 1 to fix the sk_wmem_alloc leak caused by later truesize's change in xfrm in Commit 02968ccf0125 ("sctp: count sk_wmem_alloc by skb truesize in sctp_packet_transmit"). But I should have also increased sk_wmem_alloc when head->truesize is