Re: [PATCH net] sctp: hold transport before accessing its asoc in sctp_hash_transport

2018-11-28 Thread Marcelo Ricardo Leitner
On Wed, Nov 28, 2018 at 06:36:45PM +0900, Xin Long wrote: > On Thu, Nov 22, 2018 at 2:53 AM Marcelo Ricardo Leitner > wrote: > > > > On Wed, Nov 21, 2018 at 03:47:33PM +0900, Xin Long wrote: > > > On Wed, Nov 21, 2018 at 9:46 AM Marcelo Ricardo Leitner > > > wrote: > > > > > > > > On Tue, Nov 20,

Re: [PATCH net] sctp: hold transport before accessing its asoc in sctp_hash_transport

2018-11-28 Thread Xin Long
On Thu, Nov 22, 2018 at 2:53 AM Marcelo Ricardo Leitner wrote: > > On Wed, Nov 21, 2018 at 03:47:33PM +0900, Xin Long wrote: > > On Wed, Nov 21, 2018 at 9:46 AM Marcelo Ricardo Leitner > > wrote: > > > > > > On Tue, Nov 20, 2018 at 07:52:48AM -0500, Neil Horman wrote: > > > > On Tue, Nov 20, 2018

Re: [PATCH net] sctp: hold transport before accessing its asoc in sctp_hash_transport

2018-11-21 Thread Marcelo Ricardo Leitner
On Wed, Nov 21, 2018 at 08:27:21AM -0500, Neil Horman wrote: > On Tue, Nov 20, 2018 at 10:46:26PM -0200, Marcelo Ricardo Leitner wrote: > > On Tue, Nov 20, 2018 at 07:52:48AM -0500, Neil Horman wrote: > > > On Tue, Nov 20, 2018 at 07:09:16PM +0800, Xin Long wrote: > > > > In sctp_hash_transport, it

Re: [PATCH net] sctp: hold transport before accessing its asoc in sctp_hash_transport

2018-11-21 Thread Marcelo Ricardo Leitner
On Wed, Nov 21, 2018 at 03:47:33PM +0900, Xin Long wrote: > On Wed, Nov 21, 2018 at 9:46 AM Marcelo Ricardo Leitner > wrote: > > > > On Tue, Nov 20, 2018 at 07:52:48AM -0500, Neil Horman wrote: > > > On Tue, Nov 20, 2018 at 07:09:16PM +0800, Xin Long wrote: > > > > In sctp_hash_transport, it deref

Re: [PATCH net] sctp: hold transport before accessing its asoc in sctp_hash_transport

2018-11-21 Thread Neil Horman
On Tue, Nov 20, 2018 at 10:46:26PM -0200, Marcelo Ricardo Leitner wrote: > On Tue, Nov 20, 2018 at 07:52:48AM -0500, Neil Horman wrote: > > On Tue, Nov 20, 2018 at 07:09:16PM +0800, Xin Long wrote: > > > In sctp_hash_transport, it dereferences a transport's asoc only under > > > rcu_read_lock. With

Re: [PATCH net] sctp: hold transport before accessing its asoc in sctp_hash_transport

2018-11-20 Thread Xin Long
On Wed, Nov 21, 2018 at 9:46 AM Marcelo Ricardo Leitner wrote: > > On Tue, Nov 20, 2018 at 07:52:48AM -0500, Neil Horman wrote: > > On Tue, Nov 20, 2018 at 07:09:16PM +0800, Xin Long wrote: > > > In sctp_hash_transport, it dereferences a transport's asoc only under > > > rcu_read_lock. Without hol

Re: [PATCH net] sctp: hold transport before accessing its asoc in sctp_hash_transport

2018-11-20 Thread Marcelo Ricardo Leitner
On Tue, Nov 20, 2018 at 07:52:48AM -0500, Neil Horman wrote: > On Tue, Nov 20, 2018 at 07:09:16PM +0800, Xin Long wrote: > > In sctp_hash_transport, it dereferences a transport's asoc only under > > rcu_read_lock. Without holding the transport, its asoc could be freed > > already, which leads to a

Re: [PATCH net] sctp: hold transport before accessing its asoc in sctp_hash_transport

2018-11-20 Thread Neil Horman
On Tue, Nov 20, 2018 at 07:09:16PM +0800, Xin Long wrote: > In sctp_hash_transport, it dereferences a transport's asoc only under > rcu_read_lock. Without holding the transport, its asoc could be freed > already, which leads to a use-after-free panic. > > A similar fix as Commit bab1be79a516 ("sct

[PATCH net] sctp: hold transport before accessing its asoc in sctp_hash_transport

2018-11-20 Thread Xin Long
In sctp_hash_transport, it dereferences a transport's asoc only under rcu_read_lock. Without holding the transport, its asoc could be freed already, which leads to a use-after-free panic. A similar fix as Commit bab1be79a516 ("sctp: hold transport before accessing its asoc in sctp_transport_get_ne