Re: [PATCH net] sctp: change to hold sk after auth shkey is created successfully

2019-06-26 Thread David Miller
From: Xin Long Date: Tue, 25 Jun 2019 00:21:45 +0800 > Now in sctp_endpoint_init(), it holds the sk then creates auth > shkey. But when the creation fails, it doesn't release the sk, > which causes a sk defcnf leak, > > Here to fix it by only holding the sk when auth shkey is created > successfu

Re: [PATCH net] sctp: change to hold sk after auth shkey is created successfully

2019-06-25 Thread Neil Horman
On Tue, Jun 25, 2019 at 12:21:45AM +0800, Xin Long wrote: > Now in sctp_endpoint_init(), it holds the sk then creates auth > shkey. But when the creation fails, it doesn't release the sk, > which causes a sk defcnf leak, > > Here to fix it by only holding the sk when auth shkey is created > succes

[PATCH net] sctp: change to hold sk after auth shkey is created successfully

2019-06-24 Thread Xin Long
Now in sctp_endpoint_init(), it holds the sk then creates auth shkey. But when the creation fails, it doesn't release the sk, which causes a sk defcnf leak, Here to fix it by only holding the sk when auth shkey is created successfully. Fixes: a29a5bd4f5c3 ("[SCTP]: Implement SCTP-AUTH initializat