Re: [PATCH net] sch_htb: fix crash on init failure

2017-08-29 Thread Nikolay Aleksandrov
On 30.08.2017 02:06, David Miller wrote: > > I expect that you will resubmit all of these similar fixes as a patch > series after you have sorted everything out. > > Correct? > Yes, I will. There are a few more places that need fixing, I'll resubmit them all as a set.

Re: [PATCH net] sch_htb: fix crash on init failure

2017-08-29 Thread David Miller
I expect that you will resubmit all of these similar fixes as a patch series after you have sorted everything out. Correct?

Re: [PATCH net] sch_htb: fix crash on init failure

2017-08-29 Thread Eric Dumazet
On Tue, 2017-08-29 at 11:13 -0700, Cong Wang wrote: > On Tue, Aug 29, 2017 at 11:09 AM, Eric Dumazet wrote: > > On Tue, 2017-08-29 at 20:58 +0300, Nikolay Aleksandrov wrote: > >> The commit below added a call to the ->destroy() callback for all qdiscs > >> which failed in their ->init(), but some

Re: [PATCH net] sch_htb: fix crash on init failure

2017-08-29 Thread Cong Wang
On Tue, Aug 29, 2017 at 10:58 AM, Nikolay Aleksandrov wrote: > The commit below added a call to the ->destroy() callback for all qdiscs > which failed in their ->init(), but some were not prepared for such > change and can't handle partially initialized qdisc. HTB is one of them > and if any error

Re: [PATCH net] sch_htb: fix crash on init failure

2017-08-29 Thread Nikolay Aleksandrov
On 29/08/17 21:09, Eric Dumazet wrote: > On Tue, 2017-08-29 at 20:58 +0300, Nikolay Aleksandrov wrote: >> The commit below added a call to the ->destroy() callback for all qdiscs >> which failed in their ->init(), but some were not prepared for such >> change and can't handle partially initialized

Re: [PATCH net] sch_htb: fix crash on init failure

2017-08-29 Thread Eric Dumazet
On Tue, 2017-08-29 at 11:09 -0700, Eric Dumazet wrote: > On Tue, 2017-08-29 at 20:58 +0300, Nikolay Aleksandrov wrote: > > The commit below added a call to the ->destroy() callback for all qdiscs > > which failed in their ->init(), but some were not prepared for such > > change and can't handle par

Re: [PATCH net] sch_htb: fix crash on init failure

2017-08-29 Thread Cong Wang
On Tue, Aug 29, 2017 at 11:09 AM, Eric Dumazet wrote: > On Tue, 2017-08-29 at 20:58 +0300, Nikolay Aleksandrov wrote: >> The commit below added a call to the ->destroy() callback for all qdiscs >> which failed in their ->init(), but some were not prepared for such >> change and can't handle partia

Re: [PATCH net] sch_htb: fix crash on init failure

2017-08-29 Thread Eric Dumazet
On Tue, 2017-08-29 at 20:58 +0300, Nikolay Aleksandrov wrote: > The commit below added a call to the ->destroy() callback for all qdiscs > which failed in their ->init(), but some were not prepared for such > change and can't handle partially initialized qdisc. HTB is one of them > and if any error

[PATCH net] sch_htb: fix crash on init failure

2017-08-29 Thread Nikolay Aleksandrov
The commit below added a call to the ->destroy() callback for all qdiscs which failed in their ->init(), but some were not prepared for such change and can't handle partially initialized qdisc. HTB is one of them and if any error occurs before the qdisc watchdog timer and qdisc work are initialized