Re: [PATCH net] rtnetlink: NUL-terminate IFLA_PHYS_PORT_NAME string

2017-05-04 Thread David Ahern
On 5/4/17 8:48 AM, Michal Schmidt wrote: > IFLA_PHYS_PORT_NAME is a string attribute, so terminate it with \0. > Otherwise libnl3 fails to validate netlink messages with this attribute. > "ip -detail a" assumes too that the attribute is NUL-terminated when > printing it. It often was, due to paddin

Re: [PATCH net] rtnetlink: NUL-terminate IFLA_PHYS_PORT_NAME string

2017-05-04 Thread David Miller
From: Michal Schmidt Date: Thu, 4 May 2017 16:48:58 +0200 > IFLA_PHYS_PORT_NAME is a string attribute, so terminate it with \0. > Otherwise libnl3 fails to validate netlink messages with this attribute. > "ip -detail a" assumes too that the attribute is NUL-terminated when > printing it. It ofte

[PATCH net] rtnetlink: NUL-terminate IFLA_PHYS_PORT_NAME string

2017-05-04 Thread Michal Schmidt
IFLA_PHYS_PORT_NAME is a string attribute, so terminate it with \0. Otherwise libnl3 fails to validate netlink messages with this attribute. "ip -detail a" assumes too that the attribute is NUL-terminated when printing it. It often was, due to padding. I noticed this as libvirtd failing to start o