Re: [PATCH net] rhashtable: fix sparse RCU warnings on bit lock in bucket pointer

2019-05-16 Thread Jakub Kicinski
On Thu, 16 May 2019 13:16:23 +0800, Herbert Xu wrote: > On Wed, May 15, 2019 at 01:55:01PM -0700, Jakub Kicinski wrote: > > Since the bit_spin_lock() operations don't actually dereference > > the pointer, it's fine to forcefully drop the RCU annotation. > > This fixes 7 sparse warnings per include

Re: [PATCH net] rhashtable: fix sparse RCU warnings on bit lock in bucket pointer

2019-05-15 Thread Herbert Xu
On Wed, May 15, 2019 at 01:55:01PM -0700, Jakub Kicinski wrote: > Since the bit_spin_lock() operations don't actually dereference > the pointer, it's fine to forcefully drop the RCU annotation. > This fixes 7 sparse warnings per include site. > > Fixes: 8f0db018006a ("rhashtable: use bit_spin_lock

Re: [PATCH net] rhashtable: fix sparse RCU warnings on bit lock in bucket pointer

2019-05-15 Thread Jakub Kicinski
On Thu, 16 May 2019 07:42:29 +1000, NeilBrown wrote: > On Wed, May 15 2019, Jakub Kicinski wrote: > > > Since the bit_spin_lock() operations don't actually dereference > > the pointer, it's fine to forcefully drop the RCU annotation. > > This fixes 7 sparse warnings per include site. > > > > Fixes

Re: [PATCH net] rhashtable: fix sparse RCU warnings on bit lock in bucket pointer

2019-05-15 Thread NeilBrown
On Wed, May 15 2019, Jakub Kicinski wrote: > Since the bit_spin_lock() operations don't actually dereference > the pointer, it's fine to forcefully drop the RCU annotation. > This fixes 7 sparse warnings per include site. > > Fixes: 8f0db018006a ("rhashtable: use bit_spin_locks to protect hash buc

[PATCH net] rhashtable: fix sparse RCU warnings on bit lock in bucket pointer

2019-05-15 Thread Jakub Kicinski
Since the bit_spin_lock() operations don't actually dereference the pointer, it's fine to forcefully drop the RCU annotation. This fixes 7 sparse warnings per include site. Fixes: 8f0db018006a ("rhashtable: use bit_spin_locks to protect hash bucket.") Signed-off-by: Jakub Kicinski Reviewed-by: Si