Re: [PATCH net] qed: Unlock on error in qed_vf_pf_acquire()

2017-04-30 Thread David Miller
From: Dan Carpenter Date: Fri, 28 Apr 2017 15:56:09 +0300 > My static checker complains that we're holding a mutex on this error > path. Let's goto exit instead of returning directly. > > Fixes: b0bccb69eba3 ("qed: Change locking scheme for VF channel") > Signed-off-by: Dan Carpenter Applied.

RE: [PATCH net] qed: Unlock on error in qed_vf_pf_acquire()

2017-04-30 Thread Mintz, Yuval
> My static checker complains that we're holding a mutex on this error path. > Let's goto exit instead of returning directly. > > Fixes: b0bccb69eba3 ("qed: Change locking scheme for VF channel") > Signed-off-by: Dan Carpenter > --- > Yuval, could you review this one a bit carefully and also chec

[PATCH net] qed: Unlock on error in qed_vf_pf_acquire()

2017-04-28 Thread Dan Carpenter
My static checker complains that we're holding a mutex on this error path. Let's goto exit instead of returning directly. Fixes: b0bccb69eba3 ("qed: Change locking scheme for VF channel") Signed-off-by: Dan Carpenter --- Yuval, could you review this one a bit carefully and also check that my Fix