Re: [PATCH net] pppoe: fix reception of frames with no mac header

2018-09-17 Thread David Miller
From: Guillaume Nault Date: Fri, 14 Sep 2018 16:28:05 +0200 > pppoe_rcv() needs to look back at the Ethernet header in order to > lookup the PPPoE session. Therefore we need to ensure that the mac > header is big enough to contain an Ethernet header. Otherwise > eth_hdr(skb)->h_source might acces

Re: [PATCH net] pppoe: fix reception of frames with no mac header

2018-09-14 Thread Alexander Potapenko
On Fri, Sep 14, 2018 at 4:35 PM Guillaume Nault wrote: > > On Fri, Sep 14, 2018 at 04:28:05PM +0200, Guillaume Nault wrote: > > pppoe_rcv() needs to look back at the Ethernet header in order to > > lookup the PPPoE session. Therefore we need to ensure that the mac > > header is big enough to conta

Re: [PATCH net] pppoe: fix reception of frames with no mac header

2018-09-14 Thread Guillaume Nault
On Fri, Sep 14, 2018 at 04:28:05PM +0200, Guillaume Nault wrote: > pppoe_rcv() needs to look back at the Ethernet header in order to > lookup the PPPoE session. Therefore we need to ensure that the mac > header is big enough to contain an Ethernet header. Otherwise > eth_hdr(skb)->h_source might ac

[PATCH net] pppoe: fix reception of frames with no mac header

2018-09-14 Thread Guillaume Nault
pppoe_rcv() needs to look back at the Ethernet header in order to lookup the PPPoE session. Therefore we need to ensure that the mac header is big enough to contain an Ethernet header. Otherwise eth_hdr(skb)->h_source might access invalid data. =