Re: [PATCH net] ppp: hold mutex when unbridging channels in unregister path

2020-12-24 Thread Guillaume Nault
On Thu, Dec 24, 2020 at 02:24:32PM +, Tom Parkin wrote: > On Thu, Dec 24, 2020 at 11:28:18 +0100, Guillaume Nault wrote: > > On Wed, Dec 23, 2020 at 06:47:30PM +, Tom Parkin wrote: > > > Channels are bridged using the PPPIOCBRIDGECHAN ioctl, which executes > > > with the ppp_mutex held. >

Re: [PATCH net] ppp: hold mutex when unbridging channels in unregister path

2020-12-24 Thread Tom Parkin
On Thu, Dec 24, 2020 at 11:28:18 +0100, Guillaume Nault wrote: > On Wed, Dec 23, 2020 at 06:47:30PM +, Tom Parkin wrote: > > Channels are bridged using the PPPIOCBRIDGECHAN ioctl, which executes > > with the ppp_mutex held. > > > > Unbridging may occur in two code paths: firstly an explicit >

Re: [PATCH net] ppp: hold mutex when unbridging channels in unregister path

2020-12-24 Thread Guillaume Nault
On Wed, Dec 23, 2020 at 06:47:30PM +, Tom Parkin wrote: > Channels are bridged using the PPPIOCBRIDGECHAN ioctl, which executes > with the ppp_mutex held. > > Unbridging may occur in two code paths: firstly an explicit > PPPIOCUNBRIDGECHAN ioctl, and secondly on channel unregister. The > latt

[PATCH net] ppp: hold mutex when unbridging channels in unregister path

2020-12-23 Thread Tom Parkin
Channels are bridged using the PPPIOCBRIDGECHAN ioctl, which executes with the ppp_mutex held. Unbridging may occur in two code paths: firstly an explicit PPPIOCUNBRIDGECHAN ioctl, and secondly on channel unregister. The latter may occur when closing the /dev/ppp instance or on teardown of the ch