Re: [PATCH net] pktgen: do not sleep with the thread lock held.

2019-06-06 Thread Paolo Abeni
Hi, Thank you for the feedback. On Wed, 2019-06-05 at 12:05 -0700, David Miller wrote: > From: Paolo Abeni > Date: Wed, 5 Jun 2019 14:34:46 +0200 > > > @@ -3062,20 +3062,49 @@ static int thread_is_running(const struct > > pktgen_thread *t) > > return 0; > > } > > > > -static int pktg

Re: [PATCH net] pktgen: do not sleep with the thread lock held.

2019-06-05 Thread David Miller
From: Paolo Abeni Date: Wed, 5 Jun 2019 14:34:46 +0200 > @@ -3062,20 +3062,49 @@ static int thread_is_running(const struct > pktgen_thread *t) > return 0; > } > > -static int pktgen_wait_thread_run(struct pktgen_thread *t) > +static bool pktgen_lookup_thread(struct pktgen_net *pn, stru

[PATCH net] pktgen: do not sleep with the thread lock held.

2019-06-05 Thread Paolo Abeni
Currently, the process issuing a "start" command on the pktgen procfs interface, acquires the pktgen thread lock and never release it, until all pktgen threads are completed. The above can blocks indefinitely any other pktgen command and any (even unrelated) netdevice removal - as the pktgen netdev