Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR()

2017-09-11 Thread David Miller
From: Kishon Vijay Abraham I Date: Mon, 11 Sep 2017 12:54:47 +0530 > On Saturday 09 September 2017 09:39 AM, David Miller wrote: >> Yeah let's sort this out before I apply this fix to my tree. > > I'll take this fix in linux-phy tree after -rc1 is tagged if that's okay with > you. No problem,

Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR()

2017-09-11 Thread Kishon Vijay Abraham I
Hi, On Saturday 09 September 2017 09:39 AM, David Miller wrote: > From: Dan Carpenter > Date: Fri, 8 Sep 2017 13:31:37 +0300 > >> devm_ioremap_resource() never returns NULL, it only returns error >> pointers so this test needs to be changed. >> >> Fixes: d0438bd6aa09 ("phy: add the mvebu cp110 c

Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR()

2017-09-08 Thread David Miller
From: Dan Carpenter Date: Fri, 8 Sep 2017 13:31:37 +0300 > devm_ioremap_resource() never returns NULL, it only returns error > pointers so this test needs to be changed. > > Fixes: d0438bd6aa09 ("phy: add the mvebu cp110 comphy driver") > Signed-off-by: Dan Carpenter > --- > This driver apparen

[PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR()

2017-09-08 Thread Dan Carpenter
devm_ioremap_resource() never returns NULL, it only returns error pointers so this test needs to be changed. Fixes: d0438bd6aa09 ("phy: add the mvebu cp110 comphy driver") Signed-off-by: Dan Carpenter --- This driver apparently is going through the net tree, but netdev isn't listed as handling it