Re: [PATCH net] packet: validate address length if non-zero

2019-04-26 Thread Willem de Bruijn
On Fri, Apr 26, 2019 at 11:14 AM David Laight wrote: > > From: Willem de Bruijn > > Sent: 26 April 2019 16:11 > > On Thu, Apr 25, 2019 at 11:42 AM Willem de Bruijn > > wrote: > > > > > > On Thu, Apr 25, 2019 at 10:35 AM David Laight > > > wrote: > > > > > > > > From: Willem de Bruijn > > > > >

RE: [PATCH net] packet: validate address length if non-zero

2019-04-26 Thread David Laight
From: Willem de Bruijn > Sent: 26 April 2019 16:11 > On Thu, Apr 25, 2019 at 11:42 AM Willem de Bruijn > wrote: > > > > On Thu, Apr 25, 2019 at 10:35 AM David Laight > > wrote: > > > > > > From: Willem de Bruijn > > > > Sent: 25 April 2019 14:57 > > > ... > > > > > I've just done a bit of softwa

Re: [PATCH net] packet: validate address length if non-zero

2019-04-26 Thread Willem de Bruijn
On Thu, Apr 25, 2019 at 11:42 AM Willem de Bruijn wrote: > > On Thu, Apr 25, 2019 at 10:35 AM David Laight wrote: > > > > From: Willem de Bruijn > > > Sent: 25 April 2019 14:57 > > ... > > > > I've just done a bit of software archaeology. > > > > > > > > Prior to 2.6.14-rc3 the send code ignored

Re: [PATCH net] packet: validate address length if non-zero

2019-04-25 Thread Willem de Bruijn
On Thu, Apr 25, 2019 at 10:35 AM David Laight wrote: > > From: Willem de Bruijn > > Sent: 25 April 2019 14:57 > ... > > > I've just done a bit of software archaeology. > > > > > > Prior to 2.6.14-rc3 the send code ignored sll_halen, it was only set by > > > the receive code. > > > So it is not su

RE: [PATCH net] packet: validate address length if non-zero

2019-04-25 Thread David Laight
From: Willem de Bruijn > Sent: 25 April 2019 14:57 ... > > I've just done a bit of software archaeology. > > > > Prior to 2.6.14-rc3 the send code ignored sll_halen, it was only set by the > > receive code. > > So it is not surprising that old application code leaves it as zero. > > > > The old re

Re: [PATCH net] packet: validate address length if non-zero

2019-04-25 Thread Willem de Bruijn
On Thu, Apr 25, 2019 at 5:32 AM David Laight wrote: > > From: Willem de Bruijn > > Sent: 24 April 2019 20:35 > > On Wed, Apr 24, 2019 at 3:14 PM Willem de Bruijn > > wrote: > > > > > > On Tue, Apr 23, 2019 at 2:21 PM Willem de Bruijn > > > wrote: > > > > > > > > On Tue, Apr 23, 2019 at 1:21 PM W

RE: [PATCH net] packet: validate address length if non-zero

2019-04-25 Thread David Laight
From: Willem de Bruijn > Sent: 24 April 2019 20:35 > On Wed, Apr 24, 2019 at 3:14 PM Willem de Bruijn > wrote: > > > > On Tue, Apr 23, 2019 at 2:21 PM Willem de Bruijn > > wrote: > > > > > > On Tue, Apr 23, 2019 at 1:21 PM Willem de Bruijn > > > wrote: > > > > > > > > On Tue, Apr 23, 2019 at 1:0

Re: [PATCH net] packet: validate address length if non-zero

2019-04-24 Thread Willem de Bruijn
On Wed, Apr 24, 2019 at 3:14 PM Willem de Bruijn wrote: > > On Tue, Apr 23, 2019 at 2:21 PM Willem de Bruijn > wrote: > > > > On Tue, Apr 23, 2019 at 1:21 PM Willem de Bruijn > > wrote: > > > > > > On Tue, Apr 23, 2019 at 1:04 PM Willem de Bruijn > > > wrote: > > > > > > > > On Tue, Apr 23, 201

Re: [PATCH net] packet: validate address length if non-zero

2019-04-24 Thread Willem de Bruijn
On Tue, Apr 23, 2019 at 2:21 PM Willem de Bruijn wrote: > > On Tue, Apr 23, 2019 at 1:21 PM Willem de Bruijn > wrote: > > > > On Tue, Apr 23, 2019 at 1:04 PM Willem de Bruijn > > wrote: > > > > > > On Tue, Apr 23, 2019 at 11:52 AM David Laight > > > wrote: > > > > > > > > From: Willem de Bruij

Re: [PATCH net] packet: validate address length if non-zero

2019-04-23 Thread Willem de Bruijn
On Tue, Apr 23, 2019 at 1:21 PM Willem de Bruijn wrote: > > On Tue, Apr 23, 2019 at 1:04 PM Willem de Bruijn > wrote: > > > > On Tue, Apr 23, 2019 at 11:52 AM David Laight > > wrote: > > > > > > From: Willem de Bruijn > > > > Sent: 23 April 2019 16:08 > > > > On Tue, Apr 23, 2019 at 5:59 AM Dav

Re: [PATCH net] packet: validate address length if non-zero

2019-04-23 Thread Willem de Bruijn
On Tue, Apr 23, 2019 at 1:04 PM Willem de Bruijn wrote: > > On Tue, Apr 23, 2019 at 11:52 AM David Laight wrote: > > > > From: Willem de Bruijn > > > Sent: 23 April 2019 16:08 > > > On Tue, Apr 23, 2019 at 5:59 AM David Laight > > > wrote: > > > > > > > > From: Willem de Bruijn > > > > > Sent:

Re: [PATCH net] packet: validate address length if non-zero

2019-04-23 Thread Willem de Bruijn
On Tue, Apr 23, 2019 at 11:52 AM David Laight wrote: > > From: Willem de Bruijn > > Sent: 23 April 2019 16:08 > > On Tue, Apr 23, 2019 at 5:59 AM David Laight > > wrote: > > > > > > From: Willem de Bruijn > > > > Sent: 22 December 2018 21:54 > > > > Validate packet socket address length if a len

RE: [PATCH net] packet: validate address length if non-zero

2019-04-23 Thread David Laight
From: Willem de Bruijn > Sent: 23 April 2019 16:08 > On Tue, Apr 23, 2019 at 5:59 AM David Laight wrote: > > > > From: Willem de Bruijn > > > Sent: 22 December 2018 21:54 > > > Validate packet socket address length if a length is given. Zero > > > length is equivalent to not setting an address. >

Re: [PATCH net] packet: validate address length if non-zero

2019-04-23 Thread Willem de Bruijn
On Tue, Apr 23, 2019 at 5:59 AM David Laight wrote: > > From: Willem de Bruijn > > Sent: 22 December 2018 21:54 > > Validate packet socket address length if a length is given. Zero > > length is equivalent to not setting an address. > > > > Fixes: 99137b7888f4 ("packet: validate address length") >

RE: [PATCH net] packet: validate address length if non-zero

2019-04-23 Thread David Laight
From: Willem de Bruijn > Sent: 22 December 2018 21:54 > Validate packet socket address length if a length is given. Zero > length is equivalent to not setting an address. > > Fixes: 99137b7888f4 ("packet: validate address length") > Reported-by: Ido Schimmel > Signed-off-by: Willem de Bruijn > -

Re: [PATCH net] packet: validate address length if non-zero

2018-12-23 Thread Willem de Bruijn
On Sat, Dec 22, 2018 at 6:13 PM David Miller wrote: > > From: Willem de Bruijn > Date: Sat, 22 Dec 2018 16:53:45 -0500 > > > From: Willem de Bruijn > > > > Validate packet socket address length if a length is given. Zero > > length is equivalent to not setting an address. > > > > Fixes: 99137b78

Re: [PATCH net] packet: validate address length if non-zero

2018-12-22 Thread Ido Schimmel
On Sat, Dec 22, 2018 at 04:53:45PM -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > Validate packet socket address length if a length is given. Zero > length is equivalent to not setting an address. > > Fixes: 99137b7888f4 ("packet: validate address length") > Reported-by: Ido Schimme

Re: [PATCH net] packet: validate address length if non-zero

2018-12-22 Thread David Miller
From: Willem de Bruijn Date: Sat, 22 Dec 2018 16:53:45 -0500 > From: Willem de Bruijn > > Validate packet socket address length if a length is given. Zero > length is equivalent to not setting an address. > > Fixes: 99137b7888f4 ("packet: validate address length") > Reported-by: Ido Schimmel

[PATCH net] packet: validate address length if non-zero

2018-12-22 Thread Willem de Bruijn
From: Willem de Bruijn Validate packet socket address length if a length is given. Zero length is equivalent to not setting an address. Fixes: 99137b7888f4 ("packet: validate address length") Reported-by: Ido Schimmel Signed-off-by: Willem de Bruijn --- net/packet/af_packet.c | 4 ++-- 1 file